-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Rewards v2 #837
Merged
Merged
feat: Rewards v2 #837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xrajath
force-pushed
the
feat/rewards-v2
branch
from
October 16, 2024 23:26
3832b9d
to
72cf05e
Compare
0xrajath
commented
Oct 16, 2024
0xrajath
commented
Oct 16, 2024
0xrajath
commented
Oct 16, 2024
0xrajath
commented
Oct 16, 2024
0xrajath
commented
Oct 16, 2024
0xrajath
commented
Oct 16, 2024
0xrajath
commented
Oct 17, 2024
0xrajath
commented
Oct 17, 2024
gpsanant
reviewed
Oct 17, 2024
ypatil12
reviewed
Oct 17, 2024
0xrajath
commented
Oct 18, 2024
0xrajath
commented
Nov 6, 2024
gpsanant
reviewed
Nov 8, 2024
gpsanant
reviewed
Nov 8, 2024
gpsanant
reviewed
Nov 8, 2024
ypatil12
reviewed
Nov 13, 2024
gpsanant
reviewed
Nov 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, will wait for @ypatil12 @nadir-akhtar review to merge
ypatil12
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As part of the Rewards v2 release, we need to support the following:
commission
terminology tosplit
, andglobal
terminology todefault
.Modifications
Refactoring existing
commission
terminology tosplit
, andglobal
terminology todefault
for RewardsCoordinator insrc
,script
andtest
.RewardsCoordinator
andIRewardsCoordinator
:createOperatorDirectedAVSRewardsSubmission
external function and related changes that allows AVSs to submit operator-directed rewards.setOperatorAVSSplit
external function and related changes that allows operators to set their split per AVS.setOperatorPISplit
external function and related changes that allows operators to set their split for Programmatic Incentives.processClaim
into an internal function called_processClaim
processClaims
external function and related changes that iterates over_processClaim
to allow batch claiming of rewards for earners.operatorCommissionBips()
view function togetOperatorAVSSplit()
and added logic to handle default value and operator<>avs split.getOperatorPISplit()
view function with logic to handle default value and operator PI split.RewardsCoordinatorStorage
:Updated Test Cases
Updated Storage Report
Updated Bindings
Result
Rewards v2 release.