Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log semver scan operator id as hex #802

Merged
merged 6 commits into from
Oct 31, 2024
Merged

Conversation

pschork
Copy link
Contributor

@pschork pschork commented Oct 11, 2024

Why are these changes needed?

Logging operator id as byte array is not helpful
Fix socket typo

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • I've checked the new test coverage and the coverage percentage didn't drop.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@pschork pschork requested a review from jianoaix October 11, 2024 05:29
DataAPI always uses dispersal socket
Allow cli to filter on operator id
```
+-------------+---------------------+-----------+----------------------+-----------------------+----------------------+
| SEMVER      |           INSTALL % | OPERATORS |   QUORUM 0 STAKE %   |    QUORUM 1 STAKE %   |     QUORUM 2 STAKE % |
+-------------+---------------------+-----------+----------------------+-----------------------+----------------------+
| 0.8.3       |  20.642201834862387 |        45 |    33.15679224277452 |      8.83955306598433 |   13.210911506047795 |
| <0.8.0      |   8.256880733944955 |        18 | 0.054015097747199314 |  0.025964291217224864 |                    0 |
| refused     |  0.9174311926605505 |         2 |    4.382860490796604 | 0.0013047926052436618 |                    0 |
| timeout     |   6.422018348623854 |        14 |    7.235050394332989 |    0.2290448818845607 |   2.2662084387932895 |
| filtered    | 0.45871559633027525 |         1 |                    0 | 3.142158057858368e-05 |                    0 |
| src-compile |  46.788990825688074 |       102 |   45.597099094040054 |    15.755535049527266 |    84.51559437667252 |
| 0.8.2       | 0.45871559633027525 |         1 | 0.009784179765765861 | 0.0010593853034541422 |                    0 |
| 0.0.0       |   8.715596330275229 |        19 |   3.4357264670142875 |     74.39174915868357 |                    0 |
| 0.8.0       |   7.339449541284404 |        16 |    6.128672033528587 |    0.7557579532137813 | 0.007285678486380705 |
+-------------+---------------------+-----------+----------------------+-----------------------+----------------------+
| TOTALS      |  100.00000000000001 |       218 |                  100 |    100.00000000000001 |    99.99999999999999 |
+-------------+---------------------+-----------+----------------------+-----------------------+----------------------+
```
@pschork pschork merged commit f4015d6 into master Oct 31, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants