[ci] Generate unit test coverage on PR #759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ian-shim
force-pushed
the
generate-coverage-on-pr
branch
2 times, most recently
from
5523cb0
to
e6276f6
Compare
ian-shim
force-pushed
the
generate-coverage-on-pr
branch
from
e6276f6
to
b322438
Compare
dmanc
approved these changes
Sep 13, 2024
jianoaix
approved these changes
Sep 13, 2024
| @@ -6,6 +6,7 @@ | |||
|
|
|||
| - [ ] I've made sure the lint is passing in this PR. | |||
| - [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant. | |||
| - [ ] I've checked the new test coverage and the coverage percentage didn't drop. | |||
There was a problem hiding this comment.
It's nice if coverage can be at least maintained in each PR, but it may be too difficult (passing lint and unit tests on the other hand are must)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
actions/download-artifactversionunit-testsactionChecks