feat: dockerfile for deploying contracts #755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed by kurtosis devnet because of path overwriting issues when in script/ folder directly
samlaf
commented
Sep 9, 2024
| @@ -25,7 +25,7 @@ import "forge-std/StdJson.sol"; | |||
| // forge script script/Deployer.s.sol:SetupEigenDA --rpc-url $RPC_URL --private-key $PRIVATE_KEY --broadcast -vvvv | |||
| contract SetupEigenDA is EigenDADeployer, EigenLayerUtils { | |||
|
|
|||
| string deployConfigPath = "script/eigenda_deploy_config.json"; | |||
| string deployConfigPath = "script/input/eigenda_deploy_config.json"; | |||
There was a problem hiding this comment.
had to change this path to make the kurtosis devnet work (otherwise uploading the config would overwrite the rest of the directory.
I think I changed everywhere else that depended on this but please double check. Also I feel like we might want to have this path as an arg to the run function instead of hardcoded?
0x0aa0
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Need an image for deploying contracts as part of my kurtosis inabox project. Generally think this is something we should have as well. Every time we deploy, we should create an image tagged with the release name/version number that contains the exact contracts that were deployed. This way anyone that wants to work locally can use that image to deploy to anvil or some local devnet and reproduce the contracts at that point.
Not set on the exact dockerfile; open to improvements. Also think we should have all of our ad-hoc docker images in the bake file in #754.
Published this image at https://github.com/orgs/Layr-Labs/packages/container/package/eigenda%2Fcontract-deployer. Would a kind admin soul please link that image with the eigenda repo for easier discovery. cc @anupsv
Checks