Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minibatch store interface #635

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

ian-shim
Copy link
Contributor

@ian-shim ian-shim commented Jul 12, 2024

Why are these changes needed?

Adding interface for minibatch store.
It's missing many methods to be filled later.

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@ian-shim ian-shim requested a review from pschork July 12, 2024 01:27
@ian-shim ian-shim marked this pull request as ready for review July 12, 2024 01:27
@ian-shim ian-shim force-pushed the minibatch-store-interface branch 2 times, most recently from f18ad89 to 55bc0aa Compare July 16, 2024 15:57
@ian-shim ian-shim merged commit 182ba59 into Layr-Labs:master Jul 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants