Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix node plugin integration tests #138

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Fix node plugin integration tests #138

merged 1 commit into from
Dec 20, 2023

Conversation

wmb-software-consulting
Copy link
Contributor

@wmb-software-consulting wmb-software-consulting commented Dec 20, 2023 •
edited
Loading

Why are these changes needed?

Fix node plugin integration tests

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

jianoaix
jianoaix reviewed Dec 20, 2023
View reviewed changes
Copy link
Contributor

@jianoaix jianoaix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

inabox/deploy/deploy.go
@@ -218,7 +218,10 @@ func (env *Config) RunNodePluginBinary(operation string, operator OperatorVars)
"NODE_BLS_OPERATOR_STATE_RETRIVER=" + operator.NODE_BLS_OPERATOR_STATE_RETRIVER,
"NODE_EIGENDA_SERVICE_MANAGER=" + operator.NODE_EIGENDA_SERVICE_MANAGER,
"NODE_CHURNER_URL=" + operator.NODE_CHURNER_URL,
})
"NODE_NUM_CONFIRMATIONS=0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this affect the test?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right here :

eigenda/node/plugin/config.go

Line 96 in 7f60e15

Value: 3,

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The anvil will never have 3 confirmations, so then it get stuck in an infinite loop.

eigenda/common/geth/client.go

Line 236 in 7f60e15

if receipt.BlockNumber.Uint64()+uint64(c.numConfirmations) > chainTip {

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, thanks

@wmb-software-consulting wmb-software-consulting merged commit 6593001 into Layr-Labs:master Dec 20, 2023
5 checks passed
@wmb-software-consulting wmb-software-consulting deleted the fix/node-plugin-integration-tests branch December 20, 2023 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mooselumph mooselumph mooselumph approved these changes

@jianoaix jianoaix Awaiting requested review from jianoaix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wmb-software-consulting @mooselumph @jianoaix