Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unhandled WHOIS Response for .IT #44

Closed
JAD3N opened this issue Jun 23, 2021 · 5 comments
Closed

Unhandled WHOIS Response for .IT #44

JAD3N opened this issue Jun 23, 2021 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@JAD3N
Copy link
Contributor

JAD3N commented Jun 23, 2021

Version(s) affected: all?

Description
The WHOIS server used for .IT returns an unhandled format that causes data such as contacts/registrar to be missed.

How to reproduce
Use whoiser with any .IT TLD and compare it to the actual response.

Additional context
The WHOIS response format used by whois.nic.it:

Registrar
  Organization:     Gandi SAS
  Name:             GANDI-REG
  Web:              http://www.gandi.net
  DNSSEC:           no
@JAD3N JAD3N added the bug Something isn't working label Jun 23, 2021
@JAD3N
Copy link
Contributor Author

JAD3N commented Jun 24, 2021

Here is also the structure for the nameservers:

Nameservers
  ns1.example.com
  ns2.example.com

@AndreiIgna
Copy link
Member

Hey @JAD3N

The library has only a basic WHOIS parser, that handles the most common format Label: value.
.it (and many other ccTLDs) returns data in a different format, and this can't be parsed to JSON/object yet.

If you want to take a look at it, you can see how extra parsers were added here https://github.com/LayeredStudio/whoiser/blob/master/src/parsers.js#L265
This is something I also want to improve, and in the next few weeks I'll check which WHOIS server need custom parsers to add them.

@JAD3N
Copy link
Contributor Author

JAD3N commented Jun 25, 2021

@AndreiIgna I don't mind having a look into this to see if I can handle it. Would you be able to provide a list of WHOIS servers which have different formats that are already handled? That would give me a good head start.

@JAD3N
Copy link
Contributor Author

JAD3N commented Jun 25, 2021

@AndreiIgna

I've started re-implementing and documenting the different WHOIS response structures on a new branch:
https://github.com/JAD3N/whoiser/tree/formats

I'm planning on using a different parsing structure which you can find in this file:
https://github.com/JAD3N/whoiser/blob/formats/formats/default.md

This way I should be able to accommodate a variety of ccTLD responses.

Any feedback and suggestions would be appreciated.

@jonathansampson
Copy link
Contributor

@JAD3N Check out #92; it should improve the parsing of .it considerably.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants