-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DISCUSSION] Improve style support when using icontool.py #1522
Comments
Apologies for the delay. I can't seem to replicate this issue. Could you provide another example regarding this? |
I don't have much to add. In general I had an assumption that some script was shifting
I had a list of such commands. I ran them all at once through Terminal and only discovered that the style was incorrect when I created the PR. Since you didn't find anything after a detailed explanation, there is probably nothing wrong with icontool.py. The string offset could have appeared earlier and in some other way. I just don't realize how, because I was working with appfilter.xml through Terminal. If nothing is found, you can close the issue because it happened 3 times in 30+ PRs (one time I waited for it and fixed appfilter.xml before committing), not all the time. |
The issue went away without any code modifications. |
I have a guess that the re-sorting when linking (and possibly when adding) is wrong. As a result, I have to fix appfilter.xml manually to pass the style test.
I may be wrong, so I will describe the case.
I propose to make icontool.py move the strings correctly in such a case.
The text was updated successfully, but these errors were encountered: