Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DropdownCheckboxGroup shows selected values in the input, instead of labels #624

Closed
jhp0621 opened this issue Nov 14, 2023 · 0 comments
Closed
Assignees
Labels

Comments

@jhp0621
Copy link
Contributor

jhp0621 commented Nov 14, 2023

Environment

  • @launchpad/lp-components version: 9.2.2
  • react version: 18.2.0
  • node version: 18.12

Expected Behavior

When dropdown checkbox options are selected, 1) the option labels show up in the input, 2) their ordering is from old to new.

Current Behavior

When dropdown checkbox options are selected, 1) the option values show up in the input, 2) their ordering shown is from new to old.
https://share.zight.com/QwuBobXR

Steps to Reproduce

Suggested Solution

Find corresponding option.key for the selected values and display them in the input. Flip the order of arguments for addToArray in checkbox-group's handleChange.

@jhp0621 jhp0621 added the bug label Nov 14, 2023
@jhp0621 jhp0621 self-assigned this Nov 14, 2023
@jhp0621 jhp0621 mentioned this issue Nov 14, 2023
5 tasks
@jhp0621 jhp0621 closed this as completed Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant