-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for caption to be specified for Table components #463
Comments
👍good callout. I think we could just make this a node prop that will be inserted into the tag since it wouldn't need access to any "internal" props/state (I think):
|
Is there a pattern for accepting
|
A string is a node, so it would work that way by default 🙂 My example above was an "inclusive or" of the ways it could be used. |
To be clear, I mean node as in |
Awesome, thanks for the clarification! |
We should be able to specify the text or component to use as a
<caption>
element in our Table components. We could leverage a similar pattern as established for label / labelComponent in LabeledField, i.e., accept acaption
string prop and acaptionComponent
prop that defaults to({ caption }) => <caption>{caption}</caption>
.This is related to research by @mwislek in addressing #324
The text was updated successfully, but these errors were encountered: