Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make options and value required in TabBar #419

Closed
chawes13 opened this issue Feb 11, 2020 · 1 comment · Fixed by #461
Closed

Make options and value required in TabBar #419

chawes13 opened this issue Feb 11, 2020 · 1 comment · Fixed by #461
Assignees
Milestone

Comments

@chawes13
Copy link
Contributor

chawes13 commented Feb 11, 2020

v3.31.0 introduced an enhancement where the styling will be applied correctly to the first option (if any exist), but since this is a controlled input that doesn't really address the need in terms of functionality. a Tablist should always have a tab visible, so we should require that value is set. Related to that, options should be required as well because you can't really have a value set if there are no options

@chawes13 chawes13 added the idea label Feb 11, 2020
@chawes13
Copy link
Contributor Author

Note: this would be a breaking change, but could go in v4

@dpikt dpikt removed the idea label Mar 2, 2020
@AngelMDev AngelMDev self-assigned this Nov 21, 2020
@chawes13 chawes13 added this to the v6 milestone Aug 31, 2021
@chawes13 chawes13 linked a pull request Jun 16, 2022 that will close this issue
@chawes13 chawes13 mentioned this issue Jun 23, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants