Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Select2 Filter Does Not Trigger a Change #5054

Closed
rbzachary opened this issue May 2, 2023 · 3 comments
Closed

[Bug] Select2 Filter Does Not Trigger a Change #5054

rbzachary opened this issue May 2, 2023 · 3 comments
Labels

Comments

@rbzachary
Copy link

rbzachary commented May 2, 2023

Bug report

What I did

Unselected select2 filter

What I expected to happen

The selection clears out and triggers a change

What happened

It doesn't

What I've already tried to fix it

In the select2 filter, there is a line $('#filter_'+filterKey).val(null) that I changed to $('#filter_'+filterKey).val(null).trigger('change');

Is it a bug in the latest version of Backpack?

After I run composer update backpack/crud the bug... is it still there? Backpack Pro, yes

Backpack, Laravel, PHP, DB version

When I run php artisan backpack:version the output is:

### PHP VERSION:
PHP 7.4.33 (cli) (built: Nov 19 2022 00:22:16) ( NTS )
Copyright (c) The PHP Group
Zend Engine v3.4.0, Copyright (c) Zend Technologies

### LARAVEL VERSION:
v8.83.27@e1afe088b4ca613fb96dc57e6d8dbcb8cc2c6b49

### BACKPACK PACKAGE VERSIONS:
backpack/crud: 5.4.16
backpack/filemanager: 1.1.7
backpack/pro: 1.6.0
backpack/generators: v3.3.7
@welcome
Copy link

welcome bot commented May 2, 2023

Hello there! Thanks for opening your first issue on this repo!

Just a heads-up: Here at Backpack we use Github Issues only for tracking bugs. Talk about new features is also acceptable. This helps a lot in keeping our focus on improving Backpack. If you issue is not a bug/feature, please help us out by closing the issue yourself and posting in the appropriate medium (see below). If you're not sure where it fits, it's ok, a community member will probably reply to help you with that.

Backpack communication channels:

  • Bug Reports, Feature Requests - Github Issues (here);
  • Quick help (How do I do X) - Gitter Chatroom;
  • Long questions (I have done X and Y and it won't do Z wtf) - Stackoverflow, using the backpack-for-laravel tag;
  • Showing off something you've made, asking for opinion on Backpack/Laravel matters - Reddit;

Please keep in mind Backpack offers no official / paid support. Whatever help you receive here, on Gitter, Slack or Stackoverflow is thanks to our awesome awesome community members, who give up some of their time to help their peers. If you want to join our community, just start pitching in. We take pride in being a welcoming bunch.

Thank you!

--
Justin Case
The Backpack Robot

@zachweix
Copy link
Contributor

zachweix commented May 2, 2023

I don't think it really matters, but I was trying to look for this in my email until I realized I used my work email address instead of my personal email 😄

@promatik
Copy link
Contributor

promatik commented May 8, 2023

Hi @rbzachary!
You're right, I was able to test it and check that the clear button on the field is not triggering the change event.

I'm opening a PR to fix that issue https://github.com/Laravel-Backpack/PRO/pull/152 👌

Thank you for your report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants