Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Repeatable does not work with image field types #4366

Closed
maurohmartinez opened this issue May 9, 2022 · 3 comments
Closed

[Bug] Repeatable does not work with image field types #4366

maurohmartinez opened this issue May 9, 2022 · 3 comments
Assignees
Labels

Comments

@maurohmartinez
Copy link
Member

Bug report

What I did

I am using a repeatable field with a subfield of type image.

What I expected to happen

To display all my subfield images, as it did before upgrade :)

What happened

I can see a javascript error in console.
Uncaught ReferenceError: fieldName is not defined

What I've already tried to fix it

I see that the problem is in vendor/backpack/pro/resources/views/fields/repeatable.blade.php:170
When getCleanNameArgFromInput gets called, it assumes all inputs have a name. But field image has an input of type file which doesn't have any name, causing the problem.

Is it a bug in the latest version of Backpack?

After I run composer update backpack/crud the bug... is it still there?
YES

Backpack, Laravel, PHP, DB version

When I run php artisan backpack:version the output is:

PHP VERSION:

PHP 8.1.5 (cli) (built: Apr 16 2022 00:03:52) (NTS)
Copyright (c) The PHP Group
Zend Engine v4.1.5, Copyright (c) Zend Technologies
with Zend OPcache v8.1.5, Copyright (c), by Zend Technologies

LARAVEL VERSION:

v9.11.0@598a8c84d452a66b90a3213b1d67189cc726c728

BACKPACK VERSION:

5.0.15@ec24c10ff3ee69cf0aafef9f16ec1d90c9ba9d7a

@welcome
Copy link

welcome bot commented May 9, 2022

Hello there! Thanks for opening your first issue on this repo!

Just a heads-up: Here at Backpack we use Github Issues only for tracking bugs. Talk about new features is also acceptable. This helps a lot in keeping our focus on improving Backpack. If you issue is not a bug/feature, please help us out by closing the issue yourself and posting in the appropriate medium (see below). If you're not sure where it fits, it's ok, a community member will probably reply to help you with that.

Backpack communication channels:

  • Bug Reports, Feature Requests - Github Issues (here);
  • Quick help (How do I do X) - Gitter Chatroom;
  • Long questions (I have done X and Y and it won't do Z wtf) - Stackoverflow, using the backpack-for-laravel tag;
  • Showing off something you've made, asking for opinion on Backpack/Laravel matters - Reddit;

Please keep in mind Backpack offers no official / paid support. Whatever help you receive here, on Gitter, Slack or Stackoverflow is thanks to our awesome awesome community members, who give up some of their time to help their peers. If you want to join our community, just start pitching in. We take pride in being a welcoming bunch.

Thank you!

--
Justin Case
The Backpack Robot

@pxpm
Copy link
Contributor

pxpm commented May 9, 2022

Hello @maurohmartinez . Thanks for the report and sorry for the bad experience.
I could reproduce the issue and submitted a PR to fix it, should probably be tagged by tomorrow, I will keep this open until then.

Once again, thanks for the report.

Cheers

@pxpm pxpm self-assigned this May 9, 2022
@pxpm
Copy link
Contributor

pxpm commented May 10, 2022

Hello @maurohmartinez

It's merged and tagged.

A composer update should get the fix for you.

Thanks again for the report! 👍 cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants