New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search: show loading indicator, and not found for no results #30

Open

2 tasks

superbunker opened this issue Jan 21, 2023 · 1 comment

Open

2 tasks

Search: show loading indicator, and not found for no results #30

superbunker opened this issue Jan 21, 2023 · 1 comment

Assignees

Labels

front end

Contributor

superbunker commented Jan 21, 2023 •

edited

Loading

loading indicator (eg: spinner or "loading") on first (?) load
show "nothing found" when there's no results

superbunker added this to RML Project Board

superbunker converted this from a draft issue

superbunker added the front end label

superbunker mentioned this issue

Styling search page #26

Open

superbunker moved this from 🔖 Ready to 🏗 In progress in RML Project Board

superbunker self-assigned this

Contributor Author

superbunker commented Jan 24, 2023

loading indicator:

https://lateeflab.com/display-a-loading-spinner-while-dom-is-rendering-in-reactjs/

Left out the isLoading return null conditional, which broke it.

bacarlsson86 moved this from 🏗 In progress to 👀 In review in RML Project Board

bacarlsson86 moved this from 👀 In review to ✅ Done in RML Project Board

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment