Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RegistryManager.create factory method #13

Closed
LachlanMarnham opened this issue Jan 18, 2022 · 0 comments · Fixed by #20
Closed

Add RegistryManager.create factory method #13

LachlanMarnham opened this issue Jan 18, 2022 · 0 comments · Fixed by #20
Assignees
@LachlanMarnham
Labels
code quality non-feature enhancements

Comments

@LachlanMarnham
Copy link
Owner

LachlanMarnham commented Jan 18, 2022 •
edited
Loading

RegistryManager.__init__ currently checks for namespace collisions. It would be cleaner to move the call to RegistryManager.find_namespace_collisions to a factory method so that the RegistryManager instance is never created in the event of a collision.
@LachlanMarnham LachlanMarnham self-assigned this Jan 18, 2022
@LachlanMarnham LachlanMarnham added the code quality non-feature enhancements label Jan 18, 2022
@LachlanMarnham LachlanMarnham linked a pull request Jan 18, 2022 that will close this issue
Add RegistryManager.create class factory #20
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LachlanMarnham LachlanMarnham

Labels
code quality non-feature enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add RegistryManager.create class factory LachlanMarnham/begin
1 participant
@LachlanMarnham