Skip to content
This repository has been archived by the owner on Aug 26, 2023. It is now read-only.

Afer entering an invalid API key once then leaving the dialog, errors for invalid API key don't show up again #266

Open
triallax opened this issue Feb 20, 2022 · 0 comments
Assignees
Labels
bug Something isn't working UI
Milestone

Comments

@triallax
Copy link
Member

Describe the bug
After entering an invalid API key once then closing the API key dialog, an error doesn't show up below the text field if you enter an invalid API key again (it's still not saved, but you just don't see an error).

To Reproduce
Steps to reproduce the behavior:

  1. Preess on Settings > API key
  2. Enter an invalid or bogus API key
  3. Wait for the error to show up
  4. Close the dialog, then press on "API key" to re-open it
  5. Enter an invalid or bogus API key, again
  6. The error doesn't show up

Expected behavior
The error should show up.

Smartphone (please complete the following information):

  • Device: Galaxy A51
  • OS: Android 11
  • App version: 2.0.0

Additional context
It probably has something to do with these lines, but I'm not sure:

ref.listen<Failure?>(
apiKeyStateNotifierProvider
.select((state) => state is Error ? state.failure : null),
(prev, next) {
if (next != null) {
failure.value = next;
}
},
);

@triallax triallax added bug Something isn't working UI labels Feb 20, 2022
@triallax triallax self-assigned this Mar 4, 2022
@prestosole prestosole modified the milestones: v2.0.2, v2.1.0 Jul 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working UI
Projects
None yet
Development

No branches or pull requests

2 participants