Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rojo should error when no project file is found #63

Closed
Quenty opened this issue Apr 20, 2018 · 2 comments
Closed

Rojo should error when no project file is found #63

Quenty opened this issue Apr 20, 2018 · 2 comments
Labels
scope: cli Relevant to the Rojo CLI
Milestone
0.4.5

Comments

@Quenty
Copy link
Contributor

Quenty commented Apr 20, 2018

The default behavior of

$ rojo serve
Found no project file, using default project...
Server listening on port 8000

is a bad pattern since the "Server listening on port 8000" implies all is well. Instead, rojo should warn with red and quit immediately to signal something is wrong.

I've found myself more than once thinking things are fine and syncing when they really aren't.
@LPGhatguy
Copy link
Contributor

Agreed.

The current 'impl-v2' branch fixes this, but I think I should break this for 0.4.5 as well, since the default project behavior is completely useless!

@LPGhatguy LPGhatguy added the scope: cli Relevant to the Rojo CLI label Apr 20, 2018
@LPGhatguy LPGhatguy added this to the 0.4.5 milestone Apr 20, 2018
@Quenty
Copy link
Contributor Author

Quenty commented Apr 21, 2018

Thank you!

Dekkonot pushed a commit to UpliftGames/rojo that referenced this issue Jan 11, 2024
@LPGhatguy
Improve error messages for 'serve' command.
03bae6d 
Rojo now throws an error if no project file could be found.

Fixes rojo-rbx#63.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
scope: cli Relevant to the Rojo CLI
Projects
None yet
Milestone
0.4.5
Development

No branches or pull requests
2 participants
@LPGhatguy @Quenty