Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken in Coq CI #695

Closed
SkySkimmer opened this issue Sep 25, 2024 · 3 comments · Fixed by coq/coq#19607
Closed

Broken in Coq CI #695

SkySkimmer opened this issue Sep 25, 2024 · 3 comments · Fixed by coq/coq#19607

Comments

@SkySkimmer
Copy link
Collaborator

eg https://gitlab.inria.fr/coq/coq/-/jobs/4772378
AFAICT it's since the merge of #684
@proux01
Copy link
Contributor

proux01 commented Sep 25, 2024

Ping @gares @rlepigre

@rlepigre
Copy link
Contributor

Seems like the removal of the dune-workspace file is responsible, but we don't want that file in coq-elpi itself. I could make make ci-elpi go through locally after doing touch _build_ci/elpi/dune-workspace, so I would advise you to do this from the Coq side.

@gares
Copy link
Contributor

gares commented Sep 25, 2024

Thanks @rlepigre to suggest a quick fix on the coq side.
My understanding is that passing --root would also work, but I also recall that was implemented on the Coq side, so I'm a bit puzzled.

I will be travelling tomorrow, so don't expect any action on my side before Monday. @SkySkimmer @proux01 please try the workaround above, sorry for the disruption.

@rlepigre rlepigre mentioned this issue Sep 25, 2024
Merged
@gares gares closed this as completed Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix coq-elpi CI rlepigre/coq
4 participants
@gares @rlepigre @SkySkimmer @proux01