From 137bfaf48474f59a337af866804c5ca9a8ef5105 Mon Sep 17 00:00:00 2001
From: Michael Herger <michael@herger.net>
Date: Thu, 24 Oct 2024 08:36:25 +0200
Subject: [PATCH] Revert previous change commenting out the Mac Legacy build,
 but don't expect it in the final step instead.

---
 .github/workflows/00_build.yaml | 49 +++++++++++++++++----------------
 1 file changed, 25 insertions(+), 24 deletions(-)

diff --git a/.github/workflows/00_build.yaml b/.github/workflows/00_build.yaml
index 7a762bf7a9..e178a8d180 100644
--- a/.github/workflows/00_build.yaml
+++ b/.github/workflows/00_build.yaml
@@ -21,29 +21,30 @@ on:
           - release
 
 jobs:
-  # comment out this step, as disabling it would fail the success() check later
-  # macLegacy:
-  #   name: Build LMS for Mac (Legacy)
-  #   runs-on: self-hosted
-  #   timeout-minutes: 20
-  #   env:
-  #     BASEDIR: gh-build
-  #   steps:
-  #     # we must check out here, as  otherwise the build action is not available
-  #     - name: Check out LMS code
-  #       uses: actions/checkout@v4
-  #       with:
-  #         path: server
-  #         ref: ${{ inputs.branch }}
-
-  #     - name: Launch build process
-  #       uses: ./server/.github/actions/build
-  #       with:
-  #         build-params: macosx
-  #         build-type: ${{ inputs.build_type }}
-  #         ssh-connect-string: ${{ secrets.MAC_CONNECT_STRING }}
-  #         AWS_KEY_ID: ${{ secrets.R2_KEY_ID }}
-  #         AWS_SECRET_ACCESS_KEY: ${{ secrets.R2_SECRET_ACCESS_KEY }}
+  macLegacy:
+    name: Build LMS for Mac (Legacy)
+    # disable - no longer provided starting LMS9
+    if: false
+    runs-on: self-hosted
+    timeout-minutes: 20
+    env:
+      BASEDIR: gh-build
+    steps:
+      # we must check out here, as  otherwise the build action is not available
+      - name: Check out LMS code
+        uses: actions/checkout@v4
+        with:
+          path: server
+          ref: ${{ inputs.branch }}
+
+      - name: Launch build process
+        uses: ./server/.github/actions/build
+        with:
+          build-params: macosx
+          build-type: ${{ inputs.build_type }}
+          ssh-connect-string: ${{ secrets.MAC_CONNECT_STRING }}
+          AWS_KEY_ID: ${{ secrets.R2_KEY_ID }}
+          AWS_SECRET_ACCESS_KEY: ${{ secrets.R2_SECRET_ACCESS_KEY }}
 
   mac:
     name: Build LMS for Mac (MenuBar Item)
@@ -177,7 +178,7 @@ jobs:
     runs-on: ubuntu-latest
     timeout-minutes: 2
     needs:
-      - macLegacy
+      # - macLegacy
       - mac
       - linux
       - win64