Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed dead code using #if 0 #7521

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

Rossmaxx
Copy link
Contributor

Title says it. From git blame, the code in question is from toby, 16 years old. At this point, no one knows the origin.

@zonkmachine
Copy link
Member

At this point, no one knows the origin.

Well, the commit message for the code from the two files in core is pretty clear: 9530460
*** initial (not yet enabled) support for binding mixer threads to CPUs to reduce scheduling overhead and cache misses (gives avg. 10% performance boost)**

It actually still compiles and run if you set #if true

@Rossmaxx
Copy link
Contributor Author

Ohh so this was a wip performance upgrade, which never went through. @sakertooth any chance you might need this in the future, once your refactor gets through?

@sakertooth
Copy link
Contributor

Ohh so this was a wip performance upgrade, which never went through. @sakertooth any chance you might need this in the future, once your refactor gets through?

No.

Copy link
Contributor

@sakertooth sakertooth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have many rejections to this. This is code no one bats an eye until this PR was made to remove it, so it's fine with me.

@Rossmaxx
Copy link
Contributor Author

Rossmaxx commented Oct 3, 2024

I'll let someone else take a look at this before merge as there's complaints about way too quick merges (especially by me). This is a trivial thing but i don't wanna let it slide anymore like i used to do.

@michaelgregorius michaelgregorius merged commit 79eac41 into LMMS:master Oct 7, 2024
11 checks passed
@michaelgregorius
Copy link
Contributor

I have merged this now. Anyone who'd be missing the code should at least know which file it was in. And in that case the Git history of that file could be searched and the code activated again. It's not like it is gone for good.

mmeeaallyynn pushed a commit to mmeeaallyynn/lmms that referenced this pull request Oct 27, 2024
Removed code that's has been deactivated using `#if 0`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants