macOS: Change drag copy shortcut from Command to Option #7325
+44
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| event->modifiers() & Qt::AltModifier ) | ||
| #else | ||
| event->modifiers() & Qt::ControlModifier ) | ||
| #endif |
There was a problem hiding this comment.
This code is repeated several times throughout the code. I propose to put it into a helper method with a speaking name. Doing so would also reduce the places where the #ifdef LMMS_BUILD_APPLE checks are needed/done.
There was a problem hiding this comment.
I invite anyone with better understanding of the code to do so and push directly to this branch.
Rossmaxx
reviewed
Jul 27, 2024
| @@ -141,6 +141,12 @@ constexpr const char* UI_CTRL_KEY = | |||
| #else | |||
| "Ctrl"; | |||
| #endif | |||
| constexpr const char* UI_ALT_KEY = | |||
There was a problem hiding this comment.
Just so you note, I'm planning to remove this entire file eventually, so would be good if we find a good place in case i go through it.
There was a problem hiding this comment.
Thanks for the heads up, however I would expect this to be handled as part of that removal (i.e. "refactor").
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2890