-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove debian
folder
#7311
Remove debian
folder
#7311
Conversation
This is just my opinion: The debian folder was used to include continuous integration in several environments (GCC, Clang) when Travis CI was available. It also carried copyright information for the whole project. Besides, it helped making good Debian packages, which seems to be a problem now (broken VST support). I do not know the current state of LMMS, but I would keep these features (continuous integration, copyright information). I have a different point of view regarding cooperation with distros, but I am not an active developer, so this does not seem important. |
Thanks for your insight @jasp00
We do have CI through GitHub actions. We migrated away from travis and circle ci long ago.
Don't we have a license.txt?
That issue was fixed recently by @tresf , if the fix fails, we still intend to fix it our side. We just don't need to carry technical debt from upstream.
A lot has changed since you last left. If you need clarification, better to chat on discord as others too might add to the tidbits, as I'm relatively new and don't know some of the minor aspects which changed. |
AFAIR, @jasp00 is referring to some specific patches to get compiles working properly with clang. I'm not sure how relevant they are now.
@jasp00 had added exhaustive copyright information, including information for files that don't comply with GPL2. Since we bundle samples and projects that are under different licenses, this caused violation with GPL2 as developers cannot make changes and release these files in accordance with the GPL2. The goal is to move the project to CC0, which is GPL2 compatible. This project is ongoing and needs help: https://github.com/LMMS/assets?tab=readme-ov-file#assets
I can't imagine these two issues are related but I'd be happy to help investigate in another thread if needed. @Rossmaxx is referring to this PR #7268.
This is as good of a place to discuss as any. 🍻 |
The debian folder was added as a part of 1.2 packaging and serves no purpose in master. The patches in the folder too are mostly obsolete as these fixes now landed on master. Also, these files should be handled by the distros and shouldn't belong here.
tagging @jasp00 for their opinion