Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove debian folder #7311

Merged
merged 4 commits into from
Jun 15, 2024
Merged

Remove debian folder #7311

merged 4 commits into from
Jun 15, 2024

Conversation

Rossmaxx
Copy link
Contributor

The debian folder was added as a part of 1.2 packaging and serves no purpose in master. The patches in the folder too are mostly obsolete as these fixes now landed on master. Also, these files should be handled by the distros and shouldn't belong here.

tagging @jasp00 for their opinion

@Rossmaxx Rossmaxx merged commit 68ea3f5 into LMMS:master Jun 15, 2024
10 checks passed
@Rossmaxx Rossmaxx deleted the remove-debian-folder branch June 15, 2024 02:59
FyiurAmron pushed a commit to FyiurAmron/lmms that referenced this pull request Jun 15, 2024
* removed debian folder

* removed debian entries from check-strings

* fixup verify script too
@jasp00
Copy link
Member

jasp00 commented Jun 16, 2024

This is just my opinion:

The debian folder was used to include continuous integration in several environments (GCC, Clang) when Travis CI was available. It also carried copyright information for the whole project. Besides, it helped making good Debian packages, which seems to be a problem now (broken VST support).

I do not know the current state of LMMS, but I would keep these features (continuous integration, copyright information). I have a different point of view regarding cooperation with distros, but I am not an active developer, so this does not seem important.

@Rossmaxx
Copy link
Contributor Author

Thanks for your insight @jasp00

The debian folder was used to include continuous integration in several environments (GCC, Clang) when Travis CI was available.

We do have CI through GitHub actions. We migrated away from travis and circle ci long ago.

It also carried copyright information for the whole project.

Don't we have a license.txt?

Besides, it helped making good Debian packages, which seems to be a problem now (broken VST support).

That issue was fixed recently by @tresf , if the fix fails, we still intend to fix it our side. We just don't need to carry technical debt from upstream.

I do not know the current state of LMMS

A lot has changed since you last left. If you need clarification, better to chat on discord as others too might add to the tidbits, as I'm relatively new and don't know some of the minor aspects which changed.

@tresf
Copy link
Member

tresf commented Jun 17, 2024

The debian folder was used to include continuous integration in several environments (GCC, Clang) when Travis CI was available.

We do have CI through GitHub actions. We migrated away from travis and circle ci long ago.

AFAIR, @jasp00 is referring to some specific patches to get compiles working properly with clang. I'm not sure how relevant they are now.

It also carried copyright information for the whole project.

Don't we have a license.txt?

@jasp00 had added exhaustive copyright information, including information for files that don't comply with GPL2. Since we bundle samples and projects that are under different licenses, this caused violation with GPL2 as developers cannot make changes and release these files in accordance with the GPL2. The goal is to move the project to CC0, which is GPL2 compatible. This project is ongoing and needs help: https://github.com/LMMS/assets?tab=readme-ov-file#assets

Besides, it helped making good Debian packages, which seems to be a problem now (broken VST support).

That issue was fixed recently by @tresf , if the fix fails, we still intend to fix it our side. We just don't need to carry technical debt from upstream.

I can't imagine these two issues are related but I'd be happy to help investigate in another thread if needed. @Rossmaxx is referring to this PR #7268.

I do not know the current state of LMMS

A lot has changed since you last left. If you need clarification, better to chat on discord as others too might add to the tidbits, as I'm relatively new and don't know some of the minor aspects which changed.

This is as good of a place to discuss as any. 🍻

FyiurAmron pushed a commit to FyiurAmron/lmms that referenced this pull request Jun 17, 2024
* removed debian folder

* removed debian entries from check-strings

* fixup verify script too
Rossmaxx added a commit to Reflexe/lmms that referenced this pull request Jul 16, 2024
* removed debian folder

* removed debian entries from check-strings

* fixup verify script too
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants