Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HiDPI fixes for elements based on QTreeView #6789

Merged

Conversation

michaelgregorius
Copy link
Contributor

Fix the HiDPI problems for elements that are based on QTreeView by removing the fixed point based font size from the style sheet. This affects:

  • The file browser
  • The headings of the plugin browser
  • The patch selection dialogs for GigPlayer and SoundFont player

Also make the text size of the check boxes for user content and factory content based on a point size instead of a pixel size.

Preview

File browser:
2510-QTreeViewFixes-FileBrowser

Patch selections:
2510-QTreeViewFixes-GigPatches
2510-QTreeViewFixes-SoundfontPatches

Fix the HiDPI problems for elements that are based on QTreeView by
removing the fixed point based font size from the style sheet. This
affects:
* The file browser
* The headings of the plugin browser
* The patch selection dialogs for GigPlayer and SoundFont player

Also make the text size of the check boxes for user content and factory
content based on a point size instead of a pixel size.
Adjust the classic theme so that it is consistent with the changes made to the default theme.

It was only necessary to change the font-size of the check boxes in the file browser to points because the QTreeView already does not contain any font settings.
@michaelgregorius
Copy link
Contributor Author

I have just adjusted the classic theme as well so this pull request is considered ready from my side.

@michaelgregorius michaelgregorius merged commit 0576f9d into LMMS:master Sep 22, 2023
9 checks passed
@michaelgregorius michaelgregorius deleted the 2510-HiDPI-Fix-For-QTreeViews branch September 22, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants