Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced snapping in song editor #4973

Merged
merged 68 commits into from
Jul 27, 2019
Merged

Enhanced snapping in song editor #4973

merged 68 commits into from
Jul 27, 2019

Commits on Jul 13, 2019

  1. Mostly working

    @Spekular
    Spekular committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    680d75f View commit details
    Browse the repository at this point in the history

  2. Simplify and fix snapping for pattern cloning

    @Spekular
    Spekular committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    831cb64 View commit details
    Browse the repository at this point in the history

  3. Add icon

    @Spekular
    Spekular committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    123c8da View commit details
    Browse the repository at this point in the history

  4. Adaptive Snap

    @Spekular
    Spekular committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    70a3612 View commit details
    Browse the repository at this point in the history

  5. Fix potential crash by capping snap fineness. Add space between adapt… 

    …ive snap dropdown and button
    @Spekular
    Spekular committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    dde4daa View commit details
    Browse the repository at this point in the history

  6. Fix cloning of short patterns

    @Spekular
    Spekular committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    54270a7 View commit details
    Browse the repository at this point in the history

  7. Widen song editor's default size, remove unused lines

    @Spekular
    Spekular committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    d5e7f10 View commit details
    Browse the repository at this point in the history

  8. Preserve offsets!

    @Spekular
    Spekular committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    04d3d35 View commit details
    Browse the repository at this point in the history

  9. Clamp position to be non-negative

    @Spekular
    Spekular committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    0f94d79 View commit details
    Browse the repository at this point in the history

  10. Snap modes for single clip move

    @Spekular
    Spekular committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    ee77192 View commit details
    Browse the repository at this point in the history

  11. Use modifier keys instead of toggle for snap behavior, allow differen… 

    …t snapping for selections, allow alt for fine movement
    @Spekular
    Spekular committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    4fa3d48 View commit details
    Browse the repository at this point in the history

  12. Apply enhanced snap to resizing

    @Spekular
    Spekular committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    2bef0b2 View commit details
    Browse the repository at this point in the history

  13. Lots of resize fixes

    @Spekular
    Spekular committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    f4d7092 View commit details
    Browse the repository at this point in the history

  14. Preserve latest offset instead of initial offset

    @Spekular
    Spekular committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    07eabc7 View commit details
    Browse the repository at this point in the history

  15. Refactoring

    @Spekular
    Spekular committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    56b350f View commit details
    Browse the repository at this point in the history

  16. Typo fix 1

    @Spekular
    Spekular committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    54cc582 View commit details
    Browse the repository at this point in the history

  17. Typo fix 2

    @Spekular
    Spekular committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    7fda4fa View commit details
    Browse the repository at this point in the history

  18. Fix offset when scrolled

    @Spekular
    Spekular committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    32a88a4 View commit details
    Browse the repository at this point in the history

  19. Clean up

    @Spekular
    Spekular committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    f1ab886 View commit details
    Browse the repository at this point in the history

  20. BaraMGB's suggestions from code review 

    Except the comment positioning, holding out for a response on that.
    @Spekular
    Spekular committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    1e5b75d View commit details
    Browse the repository at this point in the history

  21. More code review

    @Spekular
    Spekular committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    1698dd5 View commit details
    Browse the repository at this point in the history

  22. Proportional Snap Icon (classic)

    @Spekular
    Spekular committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    d51b633 View commit details
    Browse the repository at this point in the history

  23. Proportional Snap Icon (default)

    @Spekular
    Spekular committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    59875bb View commit details
    Browse the repository at this point in the history

  24. Update proportional snap pixmap

    @Spekular
    Spekular committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    f73e9c8 View commit details
    Browse the repository at this point in the history

  25. Proportional snap off by default

    @Spekular
    Spekular committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    80ba55b View commit details
    Browse the repository at this point in the history

  26. Display snap level when proportional snap enabled

    @Spekular
    Spekular committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    578bd09 View commit details
    Browse the repository at this point in the history

  27. Make proportional snap false at initialization

    @Spekular
    Spekular committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    73f5ce1 View commit details
    Browse the repository at this point in the history

  28. Plurals in snap size label

    @Spekular
    Spekular committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    d489763 View commit details
    Browse the repository at this point in the history

  29. Add missing "return"

    @Spekular
    Spekular committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    d51d8b4 View commit details
    Browse the repository at this point in the history

  30. Update src/gui/editors/SongEditor.cpp 

    Co-Authored-By: Hyunjin Song <[email protected]>
    @Spekular @PhysSong
    Spekular and PhysSong committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    9106dc6 View commit details
    Browse the repository at this point in the history

  31. Better resize limits

    @Spekular
    Spekular committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    34b32bf View commit details
    Browse the repository at this point in the history

  32. Consolidation attempt

    @Spekular
    Spekular committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    0a757d3 View commit details
    Browse the repository at this point in the history

  33. Also snap end position in shift mode

    @Spekular
    Spekular committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    4736c38 View commit details
    Browse the repository at this point in the history

  34. Mostly working

    @Spekular
    Spekular committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    d87cf8f View commit details
    Browse the repository at this point in the history

  35. Simplify and fix snapping for pattern cloning

    @Spekular
    Spekular committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    3602aa7 View commit details
    Browse the repository at this point in the history

  36. Add icon

    @Spekular
    Spekular committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    dac6c32 View commit details
    Browse the repository at this point in the history

  37. Adaptive Snap

    @Spekular
    Spekular committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    fbe4371 View commit details
    Browse the repository at this point in the history

  38. Fix potential crash by capping snap fineness. Add space between adapt… 

    …ive snap dropdown and button
    @Spekular
    Spekular committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    45f78b6 View commit details
    Browse the repository at this point in the history

  39. Fix cloning of short patterns

    @Spekular
    Spekular committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    2ad7401 View commit details
    Browse the repository at this point in the history

  40. Widen song editor's default size, remove unused lines

    @Spekular
    Spekular committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    b74e1fe View commit details
    Browse the repository at this point in the history

  41. Preserve offsets!

    @Spekular
    Spekular committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    eda9b48 View commit details
    Browse the repository at this point in the history

  42. Clamp position to be non-negative

    @Spekular
    Spekular committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    89dfcba View commit details
    Browse the repository at this point in the history

  43. Snap modes for single clip move

    @Spekular
    Spekular committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    b3094f4 View commit details
    Browse the repository at this point in the history

  44. Use modifier keys instead of toggle for snap behavior, allow differen… 

    …t snapping for selections, allow alt for fine movement
    @Spekular
    Spekular committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    e8a970f View commit details
    Browse the repository at this point in the history

  45. Apply enhanced snap to resizing

    @Spekular
    Spekular committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    c86ae79 View commit details
    Browse the repository at this point in the history

  46. Lots of resize fixes

    @Spekular
    Spekular committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    d879090 View commit details
    Browse the repository at this point in the history

  47. Preserve latest offset instead of initial offset

    @Spekular
    Spekular committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    d6446e4 View commit details
    Browse the repository at this point in the history

  48. Refactoring

    @Spekular
    Spekular committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    30c5806 View commit details
    Browse the repository at this point in the history

  49. Typo fix 1

    @Spekular
    Spekular committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    56bb8ab View commit details
    Browse the repository at this point in the history

  50. Typo fix 2

    @Spekular
    Spekular committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    b197bdc View commit details
    Browse the repository at this point in the history

  51. Fix offset when scrolled

    @Spekular
    Spekular committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    ef8b8cb View commit details
    Browse the repository at this point in the history

  52. Clean up

    @Spekular
    Spekular committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    ef14bf1 View commit details
    Browse the repository at this point in the history

  53. BaraMGB's suggestions from code review 

    Except the comment positioning, holding out for a response on that.
    @Spekular
    Spekular committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    e6b9c58 View commit details
    Browse the repository at this point in the history

  54. More code review

    @Spekular
    Spekular committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    d24715e View commit details
    Browse the repository at this point in the history

  55. Proportional Snap Icon (classic)

    @Spekular
    Spekular committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    3b979b3 View commit details
    Browse the repository at this point in the history

  56. Proportional Snap Icon (default)

    @Spekular
    Spekular committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    3ef3411 View commit details
    Browse the repository at this point in the history

  57. Update proportional snap pixmap

    @Spekular
    Spekular committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    23c42a1 View commit details
    Browse the repository at this point in the history

  58. Proportional snap off by default

    @Spekular
    Spekular committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    d0ba763 View commit details
    Browse the repository at this point in the history

  59. Display snap level when proportional snap enabled

    @Spekular
    Spekular committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    b10503e View commit details
    Browse the repository at this point in the history

  60. Make proportional snap false at initialization

    @Spekular
    Spekular committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    eea5a71 View commit details
    Browse the repository at this point in the history

  61. Plurals in snap size label

    @Spekular
    Spekular committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    a261a0a View commit details
    Browse the repository at this point in the history

  62. Add missing "return"

    @Spekular
    Spekular committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    ff93fc9 View commit details
    Browse the repository at this point in the history

  63. Update src/gui/editors/SongEditor.cpp 

    Co-Authored-By: Hyunjin Song <[email protected]>
    @Spekular @PhysSong
    Spekular and PhysSong committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    cc3edb6 View commit details
    Browse the repository at this point in the history

  64. Better resize limits

    @Spekular
    Spekular committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    0ee09b5 View commit details
    Browse the repository at this point in the history

  65. Consolidation attempt

    @Spekular
    Spekular committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    bac1541 View commit details
    Browse the repository at this point in the history

  66. Also snap end position in shift mode

    @Spekular
    Spekular committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    dbc90b6 View commit details
    Browse the repository at this point in the history

  67. Merge branch 'SESnap' of https://github.com/Spekular/lmms into SESnap

    @Spekular
    Spekular committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    321a0df View commit details
    Browse the repository at this point in the history

  68. Fix for changes on master

    @Spekular
    Spekular committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    0ca9358 View commit details
    Browse the repository at this point in the history