Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the link of carlabase to SHARED and explicitly link carlarack and carlapatchbay to carlabase. #2578

Merged
merged 1 commit into from
Feb 29, 2016

Conversation

ycollet
Copy link
Contributor

@ycollet ycollet commented Feb 17, 2016

A tentative commit to fix #2572 .

@Umcaruje
Copy link
Member

Hi, could you amend your commit (git commit --amend and git push -f) to be a bit more descriptive please. Something like change the link of carlabase to SHARED and explicitly link carlarack and carlapatchbay to carlabase.

@ycollet ycollet changed the title fix 2572 Change the link of carlabase to SHARED and explicitly link carlarack and carlapatchbay to carlabase. Feb 17, 2016
@ycollet
Copy link
Contributor Author

ycollet commented Feb 17, 2016

Is it OK ?
I hope I haven't made any mistake ...

@Umcaruje
Copy link
Member

Is it OK?

You changed the title of your PR, and not your commit message. You need to do this from the terminal:

# cd to your repo
git commit --amend
# This will open up a nano instance (usually). 
# Edit the commit text and press Ctrl + X and then just press Y and afterwards enter
# Then you need to force push 
git push -f

@ycollet
Copy link
Contributor Author

ycollet commented Feb 17, 2016

OK, new tentative for the commit amend.

@Umcaruje
Copy link
Member

👍 Tagging @falkTX since he's the author of carla.

@falkTX
Copy link
Contributor

falkTX commented Feb 17, 2016

Seems fine to me if it builds.

@Umcaruje
Copy link
Member

Seems fine to me if it builds.

Ok, I'll build @ycollet's branch and test it out.

@Umcaruje
Copy link
Member

Ok, built the branch, carla builds fine, and did a quick test ( Put carla in the song editor, load an instrument and play a few notes), and all works fine. FalkTX gave the green light, so I'm merging this.

Umcaruje added a commit that referenced this pull request Feb 29, 2016
Change the link of carlabase to SHARED and explicitly link carlarack and carlapatchbay to carlabase.
@Umcaruje Umcaruje merged commit 1507e4b into LMMS:master Feb 29, 2016
@tresf
Copy link
Member

tresf commented Feb 29, 2016

@Umcaruje thanks for following up and testing this. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants