-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the link of carlabase to SHARED and explicitly link carlarack and carlapatchbay to carlabase. #2578
Conversation
Hi, could you amend your commit ( |
Is it OK ? |
You changed the title of your PR, and not your commit message. You need to do this from the terminal: # cd to your repo
git commit --amend
# This will open up a nano instance (usually).
# Edit the commit text and press Ctrl + X and then just press Y and afterwards enter
# Then you need to force push
git push -f |
…and carlapatchbay to carlabase.
OK, new tentative for the commit amend. |
👍 Tagging @falkTX since he's the author of carla. |
Seems fine to me if it builds. |
Ok, I'll build @ycollet's branch and test it out. |
Ok, built the branch, carla builds fine, and did a quick test ( Put carla in the song editor, load an instrument and play a few notes), and all works fine. FalkTX gave the green light, so I'm merging this. |
Change the link of carlabase to SHARED and explicitly link carlarack and carlapatchbay to carlabase.
@Umcaruje thanks for following up and testing this. 👍 |
A tentative commit to fix #2572 .