1.1-based RT-safe fix for race condition causing #1662 #1747
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't find a way to rebase my existing pull request, so here's another one, this time against stable-1.1. Tested and works for me. Original description:
Ok, I fixed things the atomic way. By setting and reading
m_dependenciesMet
simultaneously atomically, the race condition is eliminated without adding a lock. It even gives me less clicks and pops than the lock fix I proposed earlier :) #1662