Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.1-based RT-safe fix for race condition causing #1662 #1747

Merged
merged 1 commit into from
Feb 8, 2015

Conversation

Fastigium
Copy link
Contributor

I couldn't find a way to rebase my existing pull request, so here's another one, this time against stable-1.1. Tested and works for me. Original description:

Ok, I fixed things the atomic way. By setting and reading m_dependenciesMet simultaneously atomically, the race condition is eliminated without adding a lock. It even gives me less clicks and pops than the lock fix I proposed earlier :) #1662

@tresf
Copy link
Member

tresf commented Feb 7, 2015

git cherry-pick is usually what we use, but that tends to only work if the files are still relatively similar. No worries. Thanks for the fix!

diizy added a commit that referenced this pull request Feb 8, 2015
1.1-based RT-safe fix for race condition causing #1662
@diizy diizy merged commit aea8460 into LMMS:stable-1.1 Feb 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants