Layout issues after SlicerT UI update

[zonkmachine]

System Information

Ubuntu 22.04

LMMS Version(s)

master after and including 7d35d42

Bug Summary

There are some issues with the instrument layouts after 7d35d42

The ones I've noticed are LV2 instrument layouts. I'm unsure if the cut off FX chains in #7508 are also from this commit.

Steps To Reproduce

• Drag a Caps - C* Fractal into a project and open the instrument

Screenshots / Minimum Reproducible Project

Caps LV2 - C* Fractal (before and after)

Please search the issue tracker for existing bug reports before submitting your own.

• I have searched all existing issues and confirmed that this is not a duplicate.

[zonkmachine]

@DanielKauss

[DanielKauss]

Sorry, I don't have a machine to test with at the moment, but looking at the code this is probably caused by this line here, where it seems like height and width are in the wrong order.

subWin->setMaximumSize(m_instrumentView->maximumHeight() + 12, m_instrumentView->maximumWidth() + 208);

Could you maybe quickly change the line to this to test it? If you can't I'll do it in a few days.

// fixed line
subWin->setMaximumSize(m_instrumentView->maximumWidth() + 12, m_instrumentView->maximumHeight() + 208);

If this doesn't fix it I'll look trough the code a bit more later on.

[Rossmaxx]

I'm unsure if the cut off FX chains in #7508 are also from this commit.

From my investigation, I can confirm that it is. Reverting that PR fixed the bug.

[Rossmaxx]

I have rolled out a proper fix for the effect view glitch in #7511

[Rossmaxx]

I have pushed the fix for this bug too in my PR, but haven't tested that one because I don't have any lv2 plugins yet.

[headquarter8302]

Just chiming in, the views of other tabs in the instrument view are also horribly stretched

[michaelgregorius]

IMO the instrument window is in dire need of an overhaul anyway. By default they are very small and crammed:

So it would be good if the instrument window had a larger default size so that the layouts of the different tabs have space to "breathe". The layouts should also be adjusted so that they have a reasonable resize behavior.

Having the envelope resizable is a good thing in my opinion as it allows for more precise editing. It just looks ugly because it uses pixmaps to render its background.

[messmerd]

If we are planning on overhauling the instrument window and making it larger, we should consider adding space for a Pin Connector button, preferably near the Channel spinbox. (See: #7459)

[JohannesLorenz]

Mentioning #7524 here, which might fix some of these issues.

[JohannesLorenz]

Listing all issues and adding 5 new ones. New ones:

J1: Start default Project with TripleOsc, Drag SlicerT onto the TripleOsc TrackLabelButton (TLB), Click TLB to open SlicerT
=> SlicerT seems to be not resizable. (issue closely related to #7512 ?). Not fixed in #7524.

J2: J1, but other way round
=> TripleOsc seems to be resizable (can get too small or too large). Not fixed in #7524.

J3: Open LMMS, create Zyn Track, Click TLB to open Zyn
=> The Zyn window will be too big (see fix of src/gui/instrument/InstrumentTuningView.cpp in #7524)

J4: Lv2 UI Instruments (testable if you rebase lv2-ui here) can be resized to size 0
=> Not acceptable. Fixed in #7524, especially in TabWidget

J5: Drag the preset "Kicker/SnareMarch.xpf" into the Song Editor, then open the Instrument (#5851).
=> #5851 is not observed anymore, but the effects in the InstrumentWindow are "too short". Not fixed in #7524.

Adding the OP issue here again to have one post with all:

Z1: Drag a Caps - C* Fractal into a project and open the instrument
=> Lv2InstrumentView has wrong size (see picture in OP)

[SpomJ]

I think SlicerT being resizeable at all is something that should be delayed. The only way to fix the layout issues under non-instrument tabs would be to revamp the instrument view entirely, which is a subject for The Great Redesign. We could improvise something in the mean time, of course, but that would require similar efforts without the payoff The Great Redesign provides.

[JohannesLorenz]

@SpomJ I think I fixed all issues in #7524. Which do you miss?