Outer border for melody clips is drawn one pixel too much to the right and bottom

[claell]

The melody pattern appears a little bit off (on the right side) compared to the rest.

Originally posted by @russiankumar in #5573 (comment)

Creating this issue to keep track of this bug.

[claell]

I finally tracked this down now: https://github.com/LMMS/lmms/blob/master/src/tracks/Pattern.cpp#L1126

Apparently each TCO class (instrument, sample track, beat and bassline and automation track) implement their own function for this. There is alot of overlapping functionality, so that should probably be improved in the future.

The current problem could be simply be solved by adjusting the relevant part of the paint function to behave like the one for the rest of the TCOs.

[Spekular]

Looks like the original title was correct though, the outer border is drawn too far right rather than the inner border being drawn too far left. Not only that, but it also appears to be drawn too far down on the bottom. Here's the screenshot from the OP cropped further and scaled up without interpolation, for easier viewing.

[claell]

Jup, I changed the title based on your comment in the other issue. Now I adjusted it again based on your observations. The scaled screenshot you attached shows that pretty nicely.

See the linked PR I just created. It should fix the problem.

[ryuukumar]

There is alot of overlapping functionality, so that should probably be improved in the future.

Again, a suggestion for #5592.