Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced snapping could be confusing with small values #5111

Open
RoxasKH opened this issue Aug 2, 2019 · 3 comments
Open

Enhanced snapping could be confusing with small values #5111

RoxasKH opened this issue Aug 2, 2019 · 3 comments

Comments

@RoxasKH
Copy link
Contributor

RoxasKH commented Aug 2, 2019

Speaking of #4973
It can get very difficult to move a pattern precisely with for example a 1/8 quantization without can't see it clearly.
So i'll suggest to make more vertical line appear in the grid, with less contrast compared to main ones obviously, as most daws do, and as happens also in Piano Roll.

Thanks again for your work, this new feature is anyway great, LMMS needs that

P.S: I open this issue because the PR was closed before i could comment on it.

@eagles051387
Copy link

eagles051387 commented Aug 2, 2019 via email

@RoxasKH
Copy link
Contributor Author

RoxasKH commented Aug 3, 2019

But that does not happen for me @eagles051387 , but if you have the possibility to test the new feature, too, and for you it works, i'll be fine.

@Spekular
Copy link
Member

Spekular commented Aug 3, 2019

I believe he was describing standard behavior, not what LMMS does. I read it as something like: "One key point you are missing [is that in other DAWs,] those lines usually appear when you zoom in".

I think a combination of the zoom level and snap size could be used to determine the drawing style. Perhaps snap size could set a preferred line interval (draw every snap) and zoom level sets the min/max so that bar lines are always drawn and lines always have a reasonable pixel distance between them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants