-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Carla plugin fails to build with 'develop' branch of Carla #4909
Comments
There are some other changes actually, that make it ABI incompatible between 2.0 and future 2.1 This is not yet something that LMMS needs to be concerned about, I think. See also https://kx.studio/News/?action=view&url=changes-in-kxstudio-repos-regarding-carla-and-jack2 |
As of 032c324, Travis-CI builds use |
As of falkTX/Carla@0514349 Carla 2.1 plugin ABI is now backwards compatible with 2.0 again. Note there might be some minor compiler warnings building against 2.1 of carla, since new enum values got added. but they are all optional |
@falkTX working on #4813 I encountered the same exact issue mentioned above using the tip of the The temporary fix for #4813 was to checkout the submodule at revision |
ah I forgot this part. I will update Carla so that it matches old API. |
Should be fixed now, please confirm |
Seems to work just fine, thanks! |
As of falkTX/Carla@d4a0292, Carla plugin fails to build. The API-breaking commit changed the type of
inBuffer
parameter ofNativePluginDescriptor::process
fromfloat**
toconst float**
.The conversion from
float**
toconst float**
can't be done implicitly, whilefloat**
-to-const float* const*
conversion can be implicit(in C++, not in C).This means if we want to fix the build for newer versions of Carla, we must drop support for old versions(which Mac builds use) since the only way to convert pointers between
float**
andconst float**
in C++ is explicitconst_cast
s.@falkTX
The text was updated successfully, but these errors were encountered: