Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text missing on the envelope tabs with Classic theme. #3652

Closed
zonkmachine opened this issue Jun 21, 2017 · 6 comments · Fixed by #3665
Closed

Text missing on the envelope tabs with Classic theme. #3652

zonkmachine opened this issue Jun 21, 2017 · 6 comments · Fixed by #3665
Assignees
@Umcaruje
Labels
bug gui
Milestone
1.2.0

Comments

@zonkmachine
Copy link
Member

Since 53772c0 #3569, Allow WidgetTab to use artwork tabs (@StCyr), some text is missing with the Classic Theme. I've only noticed this on the instrument plugins envelope tab as shown below. 'GENERAL SETTINGS' and the row above the envelopes beginning with 'TARGET' is missing. @Umcaruje

classic
@zonkmachine zonkmachine added this to the 1.2.0 milestone Jun 21, 2017
@Umcaruje Umcaruje self-assigned this Jun 21, 2017
@Umcaruje
Copy link
Member

I'll work on this once my exams are over (25th)

@PhysSong
Copy link
Member

Not only these text but also other texts(for example, some texts in setting window) have been disappeared.

This was referenced Jun 25, 2017
Merged
Merged
@PhysSong
Copy link
Member

PhysSong commented Jun 25, 2017 •
edited
Loading

It's just a problem of style.css and easy to fix. I sent a PR to fix this.

@PhysSong
Copy link
Member

@Umcaruje did you check my PR?

@Umcaruje
Copy link
Member

@PhysSong yes but the colors need work, I wonder if I should push to your branch or make a new PR alltogether

@PhysSong
Copy link
Member

PhysSong commented Jun 30, 2017 •
edited
Loading

@Umcaruje Okay. I'll grant you push access.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Umcaruje Umcaruje

Labels
bug gui
Projects
None yet
Milestone
1.2.0
Development

Successfully merging a pull request may close this issue.

Update classic/style.css with TabWidget, TrackView, PianoView and Fader colors PhysSong/lmms
3 participants
@Umcaruje @zonkmachine @PhysSong