Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching Helm presets crashes LMMS #2784

Closed
mestaritonttu opened this issue May 16, 2016 · 11 comments · Fixed by #3776
Closed

Switching Helm presets crashes LMMS #2784

mestaritonttu opened this issue May 16, 2016 · 11 comments · Fixed by #3776
Labels

Comments

@mestaritonttu
Copy link

Helm is open source. I used the 64-bit Windows version and reproduced on two different machines.

  1. Load Helm to VeSTige
  2. Drop some notes in the piano roll and hit play
  3. Click Browse in Helm and switch presets

It might crash the first time or after a couple of preset changes.
LMMS 1.1.90.
Helm 0.6.0.

@tresf
Copy link
Member

tresf commented May 16, 2016

Possibly related #1183, #1389, #2157, #493

In short, we desperately need someone to help with the state of VST in this DAW. Not only are several VST plugins in bad shape, but our Linux support is having problems loading VSTs at all per #1875 (#2739, #2728, #2724, #2628, #2488, #2448, #2196, #2390, #2304). Sigh... 😞

@mestaritonttu
Copy link
Author

I am ready to throw 100 euros at someone willing to fix this issue and the Grace one.

@tresf
Copy link
Member

tresf commented May 16, 2016

I am ready to throw 100 euros at someone willing to fix this issue and the Grace one.

Understood. You can create a bounty on the bug report and see if someone bites (but speaking personally, I've had no luck in this regard).

@jasp00
Copy link
Member

jasp00 commented May 20, 2016

Helm is built on the JUCE library. It would be nice if JUCE's license (GPL-2+) included an exception to combine with Steinberg's SDK. Otherwise, binary VST hosts cannot be distributed. I wonder if Helm can really be distributed in binary form, since that would be a violation of GPL, but not of Steinberg's license (I think), which is the one of my concern.

The 32-bit version loads on Linux. Following the steps above, LMMS gets locked and Helm still runs. I would like to have a look, but #2739 should be merged first. This is the first open-source VST plug-in that I see, although it is not the only one.

@jasp00
Copy link
Member

jasp00 commented May 21, 2016

I have solved some concurrency issues. Switching presets makes Helm crash with Wine sometimes, but LMMS does not get locked.

@mestaritonttu
Copy link
Author

@jasp00 Let me know how I can give you 100 euros after you crack the case. I decided not to lump the bounty together with the Grace loading problem.

@jasp00
Copy link
Member

jasp00 commented May 23, 2016

@mestaritonttu, thanks, but do not worry about me. If you are satisfied, you might donate to the project (look for Donate).

@osamaar
Copy link

osamaar commented May 23, 2016

A temporary workaround is to use LMMS' VeSTige instrument window switch preset function in instrument window instead. This indeed changes presets (right/left arrows) and the little down arrow lists all of Helm's presets (albeit without the nice filtering and categories available in Helm GUI), although the GUI seems to not reflect some of the changes when the preset changes.

VeSTige instrument window

I suppose VeSTige save/load preset can also be used although I haven't tested them myself. This makes it possible to bypass the whole preset section in Helm GUI until a proper fix is available.

@zonkmachine
Copy link
Member

LMMS 1.1.90.

Can you please test the latest development release for lmms 1.2.0 and confirm if this is fixed?
https://lmms.io/download/#windows

@mestaritonttu
Copy link
Author

I confirmed it does not crash anymore with LMMS 1.2.0 RC4 and Helm 0.9! Thanks a lot.

@zonkmachine
Copy link
Member

Great news, thanks for the feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants