Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MIDI tab not shown in instrument editor (translation issue) #2519

Closed
StCyr opened this issue Jan 26, 2016 · 4 comments
Closed

MIDI tab not shown in instrument editor (translation issue) #2519

StCyr opened this issue Jan 26, 2016 · 4 comments

Comments

@StCyr
Copy link

StCyr commented Jan 26, 2016

Hi,

The instrument editor's MIDI tab isn't shown in French.

I discussed this issue today on the IRC, and someone noticed that launching "LANG=fr lmms" on his computer only shows the "M" of "MIDI" of the instrument editor's MIDI tab; On my computer, I can't see any letter of the MIDI tab's label.

A quick workaround to this problem is to start LMMS by typing "LANG=C lmms".

I can send you a PR for updating the French translation if you want (any lmms policy to be followed here?).

Related to this, is there any reason why these windows aren't resizable? That would also fix the issue.

@Umcaruje
Copy link
Member

I can send you a PR for updating the French translation if you want (any lmms policy to be followed here?).

Please do.

Useful links: https://github.com/LMMS/lmms/wiki/Submitting-a-patch
https://github.com/LMMS/lmms/wiki/Creating-a-localization

@Umcaruje
Copy link
Member

Ok, I checked out the master branch and loaded all translation. The midi tab is visible in the french translation, but the new MISC tab is cut off. Also affected are Portugese, Dutch, and Galego.
Barely holding up are German and Polish (the text is too close to the edge).
Some pics:
screenshot from 2016-01-26 21 35 14 screenshot from 2016-01-26 21 45 27

There are more, I didn't want to spam the issue with pictures.

For comparison, this is how the english version looks:
screenshot from 2016-01-26 21 36 59

@StCyr
Copy link
Author

StCyr commented Jan 27, 2016

Here's the fix: #2521

But, if you don't mind I would prefer to try and implement your suggestion of adding a second row of tabs.

Cyrille

@StCyr
Copy link
Author

StCyr commented Jan 28, 2016

Ok, I'm starting to have something for the 2nd row implementation.

You can have a look at my progress here: https://github.com/StCyr/lmms/tree/StCyr_2ndRow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants