-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drag & Drop Deletion of Patterns #1562
Comments
... sounds like something an Apple user would say. Just remember, if you want to drag-to-nowhere delete, you should propose it everywhere... 👍 Android does this for its launcher icons, they can be "tossed" in the direction of a recycling bin. That said, I don't know if this has much value on a mouse/keyboard GUI, so I would vote to shelve this idea until if/when we get a more touch-centric interface. |
Also, this "trash a pattern" idea is generally something a user would expect to work with undo, which isn't currently implemented for song editor patterns. |
@tresf the dragging up/down + fade was inspired by my android phone/the |
That makes sense, although the entire software interface is pretty bad on a touch interface currently, so again, I vote we shelve ideas like this until if/when we can make the interface more touch friendly as a whole. :) |
@tresf Maybe we add a master "touch enhancements" issue similar to midi |
If you can find enough to justify such a thread, sure. I'm not sure we have that many. Tag them here if you find them and we can consider consolidating. |
Hmmm, if we didn't already have so easy shortcuts from before, Shift + Right click or Middle click, yes it could be something. Then my thinking goes on about autoscroll #1523 which couldn't coexist with this feature, which again makes me say no to this.
Again. Shift + right click works in LMMS 1.1.0 |
Normally yes, but I'll let @Spekular decide whether or not to close. He's started coding his own features, so I feel he's well qualified to make this determination himself! 👍 |
@tresf Alright, I've finally had time to go through all the issues. I tried to check every UI related one and organize them into groups, so perhaps some of these could be consolidated. Also I think we need a "UI" tag. There are quite a few drag n drop issues: Then there are some that are less related but still have to do with dragging: There are a couple that have to do with colors of various tracks: Three that have to do with various groups: Two about multiple monitors: Some have to do with the various browsers and related: FX Mixer stuff: Automation Stuff: Keyboard/Shortcut Stuff: Bugs: Looks: Features/Misc: Other things (non UI): |
@Spekular congratulations you just linked 60 bug reports to this one... I appreciate the diligence here, but we should be careful not to over-organize our bugs. MIDI, Jack and Sample Track were good candidates because they have had very little progress in recent history but are continually mentioned in new bug reports. I don't want to over-consolidate on everything because it makes it harder to track the smaller improvements that our developers are focusing quite a bit of attention on in recent history. |
That said, if there is one category that stands out as all being related, we can do some housekeeping, I just don't want to do it for the sake of having less open bugs. Many of these bugs you've listed above are mini-projects in themselves and will see some attention in the coming months. 👍 |
@tresf Oooooooooppps. Sorry. Wasn't thinking about that particular feature when I copied the names. |
@Spekular, thanks tremendously for the initiative. I agree those are two good candidates. Please do. First create the parent ticket linking all children. Then paste a comment in the children tickets referencing that the issue is consolidated (not closed) with some instructions to the users (feel free to model this after another consolidated item). Once I see that message, I'll review the child tickets and close as appropriate. 👍 In the case of the shortcuts issue, please ask Stian to maintain the original bug report since he's organizing that stuff. Just paste what you'd like appended and hopefully he'll add it into the original report. |
@tresf ok, just to confirm: consolidate drag n' drop, consolidate color issues, ask Stian to consolidate shortcut issues? Or consolidate color + shortcuts, collaborating with Stian on the shortcut issues? |
I feel you can just tell me (comment on the thread) as I have already done that (consolidated?) in a way, at the bottom of the table #1488 |
@Sti2nd done. I'm just not sure if the other issues should be closed as duplicates of yours and if so how they would be integrated. |
Sorry missed the drag-and-drop part. Please leave them as-is. Drag and drop needs improvement as a whole, but those requests are quite specific I feel. |
Closing as won't-fix for now, since patterns don't let you drag them out of the context of their track and this functionality likely won't change for a while. |
Being able to drag and drop a pattern from the song editor to outside the track area/outside the window area would be an intuitive way to delete patterns imo. Alternatively (as patterns seem to ignore vertical dragging), patterns could be dragged up/down past a certain limit and dropped to be deleted (with a visual cue like fading out to communicate this limit/the "impending deletion" to the user).
The text was updated successfully, but these errors were encountered: