Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tone bending dosn't work for all instruments #1121

Open
repsej opened this issue Aug 31, 2014 · 8 comments
Open

Tone bending dosn't work for all instruments #1121

repsej opened this issue Aug 31, 2014 · 8 comments

Comments

@repsej
Copy link

repsej commented Aug 31, 2014

Disable the tone bending button (with an explanation in the hint window) for those instruments that do not support it.

... or ... make it work for all instruments :D

@diizy
Copy link
Contributor

diizy commented Aug 31, 2014

On 08/31/2014 12:50 PM, repsej wrote:

Disable the tone bending button (with an explanation in the hint
window) for those instruments that do not support it.

Kind of problematic: patterns can still be copied from track to another,
and maybe you want to retain the pitch automations for them or modify
them even when the current instrument doesn't support it.

Just don't use pitch bends on instruments that don't support them...

... or ... make it work for all instruments :D

Impossible.

@repsej
Copy link
Author

repsej commented Aug 31, 2014

ok ... then maybe just some text in the hint window that explains the situation. (what you are currently doing cannot be heard.)

@repsej
Copy link
Author

repsej commented Aug 31, 2014

It is very confusing for beginners that the pitch bending seems to randomly work and not work.

@Sti2nd
Copy link
Contributor

Sti2nd commented Aug 31, 2014

I never thought of that!? This proves I am no beginner anymore! :D Good suggestion to add some explanation. By hint you mean the "What is this" function, or when you hover over something with your mouse?

@repsej
Copy link
Author

repsej commented Aug 31, 2014

Anywhere would be fine :D

I have two ideas ...

A) a blocking popup when ever you try to detune a node with a non detunable instrument?

"Warning: Please note that detune dosn't work for your currently selected instrument.

[ ok ] [ turn off warning ]"

or ...

B) As a hint text (the one in the lower left corner) when you press the detune tool.

@tresf
Copy link
Member

tresf commented Aug 31, 2014

The argument to keep this data (such in the instance that you had previously used the detuned property on an instrument which supported it) is perfectly valid, although I cannot say I agree with keeping it adjustable when it does nothing. The envelope isn't adjustable on instruments which don't support it, so I vote we remain consistant and block the feature on instruments which don't support it. It is the cleanest most consistent solution, and should require a slightly smaller effort to impliment.

@diizy
Copy link
Contributor

diizy commented Sep 1, 2014

On 09/01/2014 12:53 AM, repsej wrote:

Anywhere would be fine :D

I have two ideas ...

A) a blocking popup when ever you try to detune a node with a non
detunable instrument?

No, those are really annoying.

B) As a hint text (the one in the lower left corner) when you press
the detune tool.

This could be fine... could also be somewhat annoying, but tolerable.

@unfa
Copy link
Contributor

unfa commented Sep 19, 2014

I think a toolbar button grey-out + an explaining moue-hover hint would do the job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants