-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pip Runtime Dependencies & CRAY AMD Support #314
Draft
mdavis36
wants to merge
61
commits into
develop
Choose a base branch
from
feature/pip-runtime-deps
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+1,653
−456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he build and runtime.
…e to track build-requirements.
…ting build and docs requirements;
…IR; System + compiler specific cache directories; Clean targets for pip cache and envs.
…p package dependencies.
mdavis36
commented
Jan 17, 2025
mdavis36
changed the title
Pip Managed Runtime Dependencies
Pip Runtime Dependencies & CRAY AMD Support
Jan 17, 2025
…to feature/pip-runtime-deps
…ap pip-cache dir as well.
…ded proc per node limit to flux ATS runs, removed hip part of CI spec, added cray specs to devtools/spec-list.json, removed mpi module call from performance ats, added cray resource group for doing performance tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PIP Runtime Dependencies
Spheral +python variant
+python
. This will add python as a dependency for building spheral. It will also enable+python
for polytope.Build Time Deps
Spheral_Python_Env
function we build a virtual environment target in the build tree with dependencies listed inbuild-requirements.txt
. Allpybind11
code and documentation is generated from this environment.docs-requirements.txt
is added to the environment whenENABLE_DOCS=On
.Runtime Deps
Spheral_Python_Env
function we can generate a Virtual Env in the Install directory fromruntime-requirements.txt
.spheral-setup-venv
now only needs to copy the installed Spheral libraries into the environment at install time.The
python_build_env
andpython_runtime_env
targets are built and installed only one time in a build tree. Stamp files are created to ensurepip
isn't re-run on everymake
.Caching Builds for LC
We have
pip
cache to a local directory~/.cache/spheral_pip/
. This directory can be overridden withSPHERAL_PIP_CACHE_DIR
.CRAY AMD
Due to issues with pip dependencies being unsupported on BlueOS systems this PR requires us to make the switch over to CRAY/AMD.
ToDo :
RELEASE_NOTES.md
with notable changes.