Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caching valueset expand within a single load #21

Open
vadi2 opened this issue May 30, 2022 · 2 comments
Open

Caching valueset expand within a single load #21

vadi2 opened this issue May 30, 2022 · 2 comments

Comments

@vadi2
Copy link

vadi2 commented May 30, 2022

An idea - while loading a single Questionnaire that has a lot of questions tied to the same answer valueset, would it be worthwhile to re-use the existing available valueset expansion to reduce the number of network calls?

Screen.Recording.2022-05-30.at.7.38.32.AM.mov
@plynchnlm
Copy link
Member

That is surprising, because the code was written to cache those, so there must be a bug in it. Could post a small test case, say with two questions which cause the same ValueSet to be fetched twice?

@vadi2
Copy link
Author

vadi2 commented Jun 2, 2022

You bet, here it is:

lhcforms-21-testcase.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants