Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Requesting more than one signature causes transactions to hang #486

Open
awrichar opened this issue Dec 19, 2024 · 0 comments
Open
Labels
bug Something isn't working

Comments

@awrichar
Copy link
Contributor

What happened?

My Current draft of #483 requests these 3 endorsements (two different signatures from sender, plus endorsement/submission from notary):

attestation := []*prototk.AttestationRequest{
		// Sender confirms the initial request with a signature
		{
			Name:            "sender_transfer",
			AttestationType: prototk.AttestationType_SIGN,
			Algorithm:       algorithms.ECDSA_SECP256K1,
			VerifierType:    verifiers.ETH_ADDRESS,
			Payload:         encodedTransfer,
			PayloadType:     signpayloads.OPAQUE_TO_RSV,
			Parties:         []string{req.Transaction.From},
		},
		{
			Name:            "sender_lock",
			AttestationType: prototk.AttestationType_SIGN,
			Algorithm:       algorithms.ECDSA_SECP256K1,
			VerifierType:    verifiers.ETH_ADDRESS,
			Payload:         encodedLock,
			PayloadType:     signpayloads.OPAQUE_TO_RSV,
			Parties:         []string{req.Transaction.From},
		},
		// Notary will endorse the assembled transaction (by submitting to the ledger)
		{
			Name:            "notary",
			AttestationType: prototk.AttestationType_ENDORSE,
			Algorithm:       algorithms.ECDSA_SECP256K1,
			VerifierType:    verifiers.ETH_ADDRESS,
			Parties:         []string{notary},
		},
	}

My transaction hangs and never gets endorsed. However, if I remove either one of the AttestationType_SIGN entries from the plan, it works fine.

What did you expect to happen?

All signatures should be gathered and transaction workflow should continue.

How can we reproduce it (as minimally and precisely as possible)?

paladin1 (2).log
paladin2 (1).log

Transaction in these logs was ccdd0aa0-f03d-4bf5-b189-63b6b10b63f3.

Anything else we need to know?

No response

OS version

No response

@awrichar awrichar added the bug Something isn't working label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant