Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change payload 'any' type to 'schema' to match specification. #77

Merged
merged 9 commits into from
Nov 27, 2022

Conversation

VisualBean
Copy link
Collaborator

@VisualBean VisualBean commented Nov 25, 2022

Message Payload is denoted in the specification as the Json Schema 'Any' type.
However, according to documentation and chat ive had with the asyncapi creator, we can expect it to be the Schema type instead, this also fixies "missing" documented cases of Referenced payloads, which is not a thing with 'any'.

  • Changed Payload type from 'any' to 'schema'
  • Fixed an issue with security references, as they were being written as the full reference, but rather should simply "reference" by name.
  • Added a kafka streetlights test as well, to ensure we match.
  • Added and refactored binding tests

@VisualBean VisualBean changed the title test: move around binding tests and add more Fix: Change Payload 'any' type to 'Schema' to match specification. Nov 27, 2022
@VisualBean VisualBean changed the title Fix: Change Payload 'any' type to 'Schema' to match specification. Fix: change payload 'any' type to 'cchema' to match specification. Nov 27, 2022
@VisualBean VisualBean changed the title Fix: change payload 'any' type to 'cchema' to match specification. Fix: change payload 'any' type to 'schema' to match specification. Nov 27, 2022
@VisualBean VisualBean changed the title Fix: change payload 'any' type to 'schema' to match specification. fix: change payload 'any' type to 'schema' to match specification. Nov 27, 2022
@VisualBean VisualBean marked this pull request as ready for review November 27, 2022 12:08
@VisualBean VisualBean merged commit 3a7b96a into main Nov 27, 2022
@VisualBean VisualBean deleted the alex/moveandrefactortests branch November 27, 2022 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant