-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add cultureinfo to reader/writer settings. #152
feat: add cultureinfo to reader/writer settings. #152
Conversation
Added culture info to date time parsing and writing
As per usual feel free to push back on anything you don't agree with :) |
test/LEGO.AsyncAPI.Tests/Serialization/SpecialCharacterStringExtensionsTests.cs
Outdated
Show resolved
Hide resolved
src/LEGO.AsyncAPI.Readers/Exceptions/AsyncApiUnsupportedSpecVersionException.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only a few things, but otherwise I am happy with it
Definitely not against splitting unit tests apart. |
Thanks a ton @ByronMayne, great addition to the project. |
About the PR
The unit tests are currently failing to run on linux but work on windows due to differences with date time parsing and newlines. In this PR I have done the following
Changelog
Follow up questions
JsonHelper
,YamlConverter
, and previouslyStringExtensions
. Would it make sense to combine them into either theConfiguration
in this review or have them as an instance that is passed around as a context?