Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model exhaust air removal between glazing and air-permeable interior roller blind #172

Open
christoph-maurer opened this issue Jan 11, 2024 · 2 comments

Comments

@christoph-maurer
Copy link
Contributor

In #144 , @vidanovic @simon-wacker and @christoph-maurer have implemented the option to define a constant forced convection in a gap. This serves well for exhaust air removal between a glazing and an interior roller blind which is not permeable for air.

As discussed with @dccurcija and @vidanovic , Fraunhofer ISE wants to develop a model for exhaust air removal between a glazing and an air-permeable interior roller blind. A thermal-pneumatic network needs to be developed to determine the air flow through the blind and the vertical distribution of the temperatures in the gap and the blind. For this network, we probably need a very good solver. Therefore, the Ceres solver is planned to be integrated in #171 .

@vidanovic
Copy link
Collaborator

@christoph-maurer Having additional solver is great for us. However, in order for this to be accepted in WCE main branch, it must compile and work under Windows, MacOS and Ubuntu. You can actually see that automated tests are already set up. Second thing is that external projects should be added through CMake. For example, WCE is using GTest as external project:

if( DOWNLOAD_GTEST STREQUAL ON ) # Do not need gtest since it will be processed by E+
# include(CMakeLists-GTest.txt)
configure_file(CMakeLists.txt.in ${CMAKE_CURRENT_BINARY_DIR}/googletest-download/CMakeLists.txt)
execute_process(COMMAND ${CMAKE_COMMAND} -G "${CMAKE_GENERATOR}" .
WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/googletest-download )
execute_process(COMMAND ${CMAKE_COMMAND} --build .
WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/googletest-download )
# Prevent GoogleTest from overriding our compiler/linker options
# when building with Visual Studio
set(gtest_force_shared_crt ON CACHE BOOL "" FORCE)
# Add googletest directly to our build. This adds
# the following targets: gtest, gtest_main, gmock
# and gmock_main
add_subdirectory(${CMAKE_CURRENT_BINARY_DIR}/googletest-src
${CMAKE_CURRENT_BINARY_DIR}/googletest-build)
# Now simply link your own targets against gtest, gmock,
# etc. as appropriate
include_directories( ${CMAKE_CURRENT_BINARY_DIR}/googletest-src/include )
endif ()

I have another project where I use eigen as externa project:
https://github.com/LBNL-ETA/HygroThermFEM
Question for @RDmitchell and @dccurcija if it is ok to give @christoph-maurer and @simon-wacker access to HygroThermFem (https://github.com/LBNL-ETA/HygroThermFEM) so they can see an example on how is that done there?

@vidanovic
Copy link
Collaborator

It seem that ceres also have github:
https://github.com/ceres-solver/ceres-solver

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants