Create a new TaskMonitor each time to avoid flaky tests. #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this PR
This PR cleans the state polluted by
org.apache.hadoop.hbase.monitoring.TestTaskMonitor.testDoNotPurgeRPCTask
.It may be better to clean state pollutions so that some other tests won't fail in the future due to the shared state pollution.
Reproduce the test failure
Expected result:
Actual result:
[ERROR] Failures: [ERROR] testDoNotPurgeRPCTask:144 RPC Tasks have been purged! expected:<10> but was:<20>
Why the test fails
rpcTasks
, butrpcTasks
is not completely purged when the test ends. So next time the test starts, the remaining RPC tasks lead to an assertion failure.Fix
Create a new
TaskMonitor
each time to avoid pollution similar to the other tests (e.g.,testTaskMonitorBasics
,testTasksGetAbortedOnLeak
) inTestTaskMonitor
.