Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Nan equals Nan #347

Open
loneylee opened this issue Mar 8, 2023 · 0 comments
Open

Support Nan equals Nan #347

loneylee opened this issue Mar 8, 2023 · 0 comments

Comments

@loneylee
Copy link

loneylee commented Mar 8, 2023

In spark UT GlutenDataFrameAggregateSuite

val nan1 = java.lang.Float.intBitsToFloat(0x7f800001)
val nan2 = java.lang.Float.intBitsToFloat(0x7fffffff)
val nan3 = Float.NaN
// gluten count(distinct ) = 3
// spark count(distinct ) = 1

how to fix?

bool equalsOp(A a, B b)
{
    if constexpr (std::is_same_v<A, B>)
    {
        // add begin
        if (isNaN(a) && isNaN(b)) 
        {
            return true;
        }
        // add end
        return a == b;
    }

    /// float vs float
    if constexpr (std::is_floating_point_v<A> && std::is_floating_point_v<B>)
        return a == b;
    
    ...
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant