This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
Convert Employee Commands to CSharpFunctionalExtensions #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seangwright
reviewed
Sep 10, 2023
| @@ -2,6 +2,7 @@ | |||
| <PropertyGroup> | |||
| <LangVersion>latest</LangVersion> | |||
| <Nullable>enable</Nullable> | |||
| <WarningsAsErrors>CS8600;CS8602;CS8603</WarningsAsErrors> | |||
| <EnforceCodeStyleInBuild>true</EnforceCodeStyleInBuild> | |||
| <TreatWarningsAsErrors>true</TreatWarningsAsErrors> | |||
| namespace PayrollProcessor.Core.Domain.Intrastructure.Operations.Commands; | ||
|
|
||
| /// <summary> | ||
| /// TODO: Temporarily named after the Strangler Fig Pattern as this serves as an implementation of <see cref="ICommandDispatcher"/> migrating to CSharpFunctionalExtensions from LanguageExt. |
There was a problem hiding this comment.
Have you done this kind of naming in a project before? I haven't but I like the idea of calling this type out explicitly. That way, you know it should eventually be renamed when it takes over.
There was a problem hiding this comment.
I haven't done this before but the approach was mentioned in Code That Fits In Your Head and I couldn't think of a better name so I figured calling it out explicitly would be best while the code is in migration state.
| @@ -34,7 +35,7 @@ public EmployeeCreate(ICommandDispatcher dispatcher, IEntityIdGenerator generato | |||
| OperationId = "Employees.Create", | |||
| Tags = new[] { "Employees" }) | |||
| ] | |||
| public override Task<ActionResult<Employee>> HandleAsync([FromBody] EmployeeCreateRequest request, CancellationToken token) | |||
| public override ActionResult<Employee> Handle([FromBody] EmployeeCreateRequest request) | |||
There was a problem hiding this comment.
Do you drop the Async suffix most of the time now? I think Microsoft s current guidance is to only use it if there is also an existing sync API of the same name...
But I've seen a lot of modern code go both ways.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Purpose
Change Type
Data Persistence Changes
N/A
Configuration Changes
N/A