From b21a2818bc72f53ea93e149489cb5a5d3c165b28 Mon Sep 17 00:00:00 2001 From: ColdsteelRail <574252631@qq.com> Date: Tue, 15 Oct 2024 15:50:13 +0800 Subject: [PATCH] refactor getPodsToDelete comment --- pkg/controllers/collaset/synccontrol/scale.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/controllers/collaset/synccontrol/scale.go b/pkg/controllers/collaset/synccontrol/scale.go index e5fcae57..bffe4117 100644 --- a/pkg/controllers/collaset/synccontrol/scale.go +++ b/pkg/controllers/collaset/synccontrol/scale.go @@ -58,11 +58,11 @@ func getPodsToDelete(filteredPods []*collasetutils.PodWrapper, replaceMapping ma } if replacePairPod, exist := replaceMapping[pod.Name]; exist && replacePairPod != nil { - // don't scaleIn new pod until origin pod is deleted, if you want to delete new pod, please delete it by label + // don't selective scaleIn newPod (and its originPod) until replace finished if replacePairPod.ToDelete { continue } - // new pod not service available, just scaleIn it + // when scaleIn origin Pod, newPod should be deleted if not service available if _, serviceAvailable := replacePairPod.Labels[appsv1alpha1.PodServiceAvailableLabel]; !serviceAvailable { needDeletePods = append(needDeletePods, replacePairPod) }