Skip to content

Commit

Permalink
Merge pull request #3294 from acrobat/test-php-8.2
Browse files Browse the repository at this point in the history
[AllBundles] Enable CI testing on php 8.2
  • Loading branch information
acrobat authored Jun 16, 2023
2 parents e81ea01 + 94e743c commit df6f35e
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 7 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,17 +14,17 @@ jobs:
strategy:
fail-fast: false
matrix:
php: ['8.0', '8.1']
php: ['8.0', '8.1', '8.2']
deps: ['stable']
symfony: [''] # Don't lock to a specific symfony version by default
include:
# Test lowest dependencies
- deps: 'lowest'
php: 8.0
php: '8.0'

# Test latest php with LTS versions.
- deps: 'lts'
php: 8.1
php: '8.2'
symfony: '^5.4'

steps:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,8 @@ class ListWidgetTest extends TestCase
{
public function testWidget()
{
$views = new \ArrayIterator();
$views->vars = ['errors' => [new FormError('bang')]];
$view = new FakeView();
$view->offsetSet('a', $views);
$view->offsetSet('a', ['vars' => ['errors' => [new FormError('bang')]]]);

$widget = $this->createMock(FormWidget::class);
$builder = $this->createMock(FormBuilder::class);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ class LoaderTest extends TestCase
const TEST_DATA_LOCALE = 'en';
const TEST_DATA_KEYWORD = 'validation.ok';
const TEST_DATA_TEXT = 'Everything ok';
private Loader $loader;

public function setUp(): void
{
Expand All @@ -27,7 +28,6 @@ public function setUp(): void
$translationRepository = $this->createMock(TranslationRepository::class);
$translationRepository->method('findBy')->willReturn([$translation]);

/* @var Loader loader */
$this->loader = new Loader();
$this->loader->setTranslationRepository($translationRepository);
}
Expand Down

0 comments on commit df6f35e

Please sign in to comment.