Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Audio Playback Feature #1469

Open
kyoaku opened this issue Oct 1, 2024 · 3 comments
Open

[FEAT] Audio Playback Feature #1469

kyoaku opened this issue Oct 1, 2024 · 3 comments

Comments

@kyoaku
Copy link

kyoaku commented Oct 1, 2024

Hello PlanarAlly Team,

I’ve developed an audio management feature that allows Dungeon Masters to upload, select, and control audio playback for players during sessions. I currently use this feature in my own games (outside of PlanarAlly), and I believe it could be a useful addition to PlanarAlly.

You can find the project and details on my gitlab repo : vttaudiostream

Thanks for considering!

Kyoaku

@Kruptein
Copy link
Owner

Kruptein commented Oct 2, 2024

Hey, thanks for reaching out.
The topic of audio playback has come up before so I definitely wouldn't mind integrating with something.

I'm not yet sure how the actual integration would work from a UI point of view. So if you have some suggestions there, let me know.

@kyoaku
Copy link
Author

kyoaku commented Oct 2, 2024

Okay, I will try to integrate my code into your project and then submit a pull request to have a starting point and possibly think about how to integrate it into the UI.

@kyoaku
Copy link
Author

kyoaku commented Oct 20, 2024

Hi, I just created a fork with the audio streaming feature.

https://github.com/kyoaku/PlanarAlly/tree/feature/audio-stream

There will probably be some adjustments to make (I'm neither a Python nor Vue developer, and I'm not a regular contributor on GitHub either). This could be considered as a starting point for integrating sound into the project.

At the moment, it only searches for MP3 files in the root of the assets directory.

The DM will be able to preview an MP3 and start playing it (or another) for the players. They will also have the option to play the audio in a loop for the players.

image

On the players' side, they will be able to pause, resume playback, and adjust the volume.

image

Note: I’m already using the same mechanism in a separate Docker container (I currently have two open pages, PlanarAlly and the system I’m proposing, and it works quite well). But as mentioned above, this can be seen as a starting point for a more complete feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants