Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

background-image doesn't cover bleed area #1943

Closed
pmjdebruijn opened this issue Aug 25, 2023 · 4 comments
Closed

background-image doesn't cover bleed area #1943

pmjdebruijn opened this issue Aug 25, 2023 · 4 comments
Labels
bug Existing features not working as expected
Milestone
60.0

Comments

@pmjdebruijn
Copy link
Contributor

When using background-image, the bleed area remains white, see the following test case:

background-image-bleed-bug.zip

This may also illustrate another bug, when using named pages, a pagebreak gets inserted when you wouldn't expect it...
@liZe liZe added the bug Existing features not working as expected label Aug 25, 2023
@liZe
Copy link
Member

liZe commented Aug 25, 2023

Hi!

Thanks for this bug report.

Could you please open a separate issue for the page break introduced by the page name?

@pmjdebruijn pmjdebruijn mentioned this issue Aug 25, 2023
Closed
@pmjdebruijn
Copy link
Contributor Author

pmjdebruijn commented Aug 25, 2023 •
edited
Loading

I just noticed that this is the proper way to scale the background-image
https://developer.mozilla.org/en-US/docs/Web/CSS/image-resolution

Updated test case: background-image-bleed-bug.zip

The initial reported issue still persists however.

@liZe liZe closed this as completed in 3fdd3c5 Aug 25, 2023
@liZe
Copy link
Member

liZe commented Aug 25, 2023

Should now be fixed, feedback welcome!

@liZe liZe added this to the 60.0 milestone Aug 25, 2023
@pmjdebruijn
Copy link
Contributor Author

Confirmed fixed.

netbsd-srcmastr referenced this issue in NetBSD/pkgsrc Oct 15, 2023
@kleink
py-weasyprint: Update to 60.1.
a5fb891 
Version 60.1
------------

Released on 2023-09-29.

Bug fixes:

* `#1973 <https://github.com/Kozea/WeasyPrint/issues/1973>`_:
  Fix crash caused by wrong UTF-8 indices


Version 60.0
------------

Released on 2023-09-25.

New features:

* `#1903 <https://github.com/Kozea/WeasyPrint/issues/1903>`_:
  Print form fields
* `#1922 <https://github.com/Kozea/WeasyPrint/pull/1922>`_:
  Add support for textLength and lengthAdjust in SVG text elements
* `#1965 <https://github.com/Kozea/WeasyPrint/issues/1965>`_:
  Handle <wbr> tag
* `#1970 <https://github.com/Kozea/WeasyPrint/pull/1970>`_:
  Handle y offset of glyphs
* `#1909 <https://github.com/Kozea/WeasyPrint/issues/1909>`_:
  Add a --timeout option

Bug fixes:

* `#1887 <https://github.com/Kozea/WeasyPrint/pull/1887>`_:
  Fix footnote-call displayed incorrectly for some fonts
* `#1890 <https://github.com/Kozea/WeasyPrint/pull/1890>`_:
  Fix page-margin boxes layout algorithm
* `#1908 <https://github.com/Kozea/WeasyPrint/pull/1908>`_:
  Fix IndexError when rendering PDF version 1.4
* `#1906 <https://github.com/Kozea/WeasyPrint/issues/1906>`_:
  Apply text transformations to first-letter pseudo elements
* `#1915 <https://github.com/Kozea/WeasyPrint/pull/1915>`_:
  Avoid footnote appearing before its call
* `#1934 <https://github.com/Kozea/WeasyPrint/pull/1934>`_:
  Fix balance before "column-span: all"
* `#1935 <https://github.com/Kozea/WeasyPrint/issues/1935>`_:
  Only draw required glyph with OpenType-SVG fonts
* `#1595 <https://github.com/Kozea/WeasyPrint/issues/1595>`_:
  Don’t draw clipPath when defined after reference
* `#1895 <https://github.com/Kozea/WeasyPrint/pull/1895>`_:
  Don’t ignore min-width when computing cell size
* `#1899 <https://github.com/Kozea/WeasyPrint/pull/1899>`_:
  Fix named pages inheritance
* `#1936 <https://github.com/Kozea/WeasyPrint/pull/1936>`_:
  Avoid page breaks caused by children of overflow hidden boxes
* `#1943 <https://github.com/Kozea/WeasyPrint/issues/1943>`_:
  Use bleed area for page’s painting area
* `#1946 <https://github.com/Kozea/WeasyPrint/issues/1946>`_:
  Use margin box of children to define available width for leaders
@MWedl MWedl mentioned this issue Oct 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Existing features not working as expected
Projects
None yet
Milestone
60.0
Development

No branches or pull requests
2 participants
@pmjdebruijn @liZe