Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SVG: Wrong fill colors for some "use"d paths #1370

Closed
pbregener opened this issue Jun 1, 2021 · 2 comments
Closed

SVG: Wrong fill colors for some "use"d paths #1370

pbregener opened this issue Jun 1, 2021 · 2 comments
Labels
bug Existing features not working as expected
Milestone
53.0

Comments

@pbregener
Copy link
Contributor

pbregener commented Jun 1, 2021 •
edited
Loading

I encountered this when confirming the fix for #1369. The result/effect is largely the same as seen in #1365, but I have no idea if the underlying problem is related.

I'll skip the comparison between current and previous versions of weasyprint here, as the problem is quite obvious: The white letters in the heading should be black. And I can confirm that the SVG renders correctly in v52.5.

image

To reproduce use

<html>
<body>
<img src="https://raw.githubusercontent.com/pbregener/weasyprint-data/main/issue-1370.svg" style="width: 100%;">
</body>
</html>
@pbregener pbregener mentioned this issue Jun 1, 2021
Closed
@liZe liZe closed this as completed in edf47f5 Jun 1, 2021
@liZe
Copy link
Member

liZe commented Jun 1, 2021

Oh, edf47f5 fixes everything … but the little hyphen 😒.

@liZe liZe reopened this Jun 1, 2021
@liZe liZe closed this as completed in 41d4a26 Jun 1, 2021
@liZe
Copy link
Member

liZe commented Jun 1, 2021

It should be fixed for good now. Thanks again for your bug reports.

We need a much better test suite.

@liZe liZe added the bug Existing features not working as expected label Jun 1, 2021
@liZe liZe added this to the 53.0 milestone Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Existing features not working as expected
Projects
None yet
Milestone
53.0
Development

No branches or pull requests
2 participants
@liZe @pbregener