Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphTrainableModel#internalPredict works only with one-dimensional predictions #327

Closed
juliabeliaeva opened this issue Jan 19, 2022 · 2 comments · Fixed by #328
Closed
Milestone

Comments

@juliabeliaeva
Copy link
Contributor

It should be possible to make predictions of multiple-dimensions, for example, images, like in the Autoencoder example. However, the linked example fails at https://github.com/JetBrains/KotlinDL/blob/11d4eb175323b61d2e709d4133cbbde49c033746/api/src/main/kotlin/org/jetbrains/kotlinx/dl/api/core/GraphTrainableModel.kt#L698 as predictionsTensor has differrent dimentionality from dst.

@juliabeliaeva
Copy link
Contributor Author

The simplest fix would be to just linearize predictionsTensor to a FloatArray. This will allow to keep the current api and to make the Autoencoder example work (we already can show FloatArray images in the ImagePanel).
If this is ok, I'll send a pr.

@zaleslaw zaleslaw assigned zaleslaw and unassigned zaleslaw Jan 24, 2022
@zaleslaw
Copy link
Collaborator

I see this problem, please send a PR to fix that, @juliabeliaeva

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants